ROSCI infra for live camera testing#3094
ROSCI infra for live camera testing#3094SamerKhshiboun merged 1 commit intorealsenseai:ros2-developmentfrom
Conversation
| print( 'Syntax: ' + ourname + ' [options] ' ) | ||
| print( 'Options:' ) | ||
| print( ' -h, --help Usage help' ) | ||
| print( ' --debug Turn on debugging information (does not include LibRS debug logs; see --rslog)' ) |
There was a problem hiding this comment.
@kadiredd, does the --debug param being utilized anywhere? --rslog?
| print( ' -h, --help Usage help' ) | ||
| print( ' --debug Turn on debugging information (does not include LibRS debug logs; see --rslog)' ) | ||
| print( ' -r, --regex Run all tests whose name matches the following regular expression' ) | ||
| print( ' --device <> Run only on the specified device; list of devices separated by ',', No white spaces' ) |
There was a problem hiding this comment.
@kadiredd, please also mention what happens if --device param is not passed.
| print( 'Options:' ) | ||
| print( ' -h, --help Usage help' ) | ||
| print( ' --debug Turn on debugging information (does not include LibRS debug logs; see --rslog)' ) | ||
| print( ' -r, --regex Run all tests whose name matches the following regular expression' ) |
| if device.upper() in connected_devices: | ||
| log.i('Running tests on device:', device) | ||
| #for testname in test_list: | ||
| cmd = command(device.lower(), testname) |
There was a problem hiding this comment.
@kadiredd, will it work if we send regex directly to testname?
There was a problem hiding this comment.
Yes, this regex is either full test name or keyword and the same is appended in pytest command
| sys.exit( 2 ) | ||
|
|
||
| def command(dev_name, test=None): | ||
| cmd = ['pytest-3'] |
There was a problem hiding this comment.
@kadiredd, please maintain the indentation throughout the whole file. In some places its 4 spaces and in some places more than 4.
| print( 'Options:' ) | ||
| print( ' -h, --help Usage help' ) | ||
| print( ' -r, --regex Run all tests whose name matches the following regular expression' ) | ||
| print( ' ex: --regex test_camera_imu; -r d415_basic') |
There was a problem hiding this comment.
I would prefer "example:" or "e.g.,:", not "ex:"
SamerKhshiboun
left a comment
SamerKhshiboun
left a comment
There was a problem hiding this comment.
Looks good to me, only small comment..
Nir-Az
left a comment
Nir-Az
left a comment
There was a problem hiding this comment.
Looks like a good point to start with
|
will re-open in next minute. closing and re-opening is for re-triggering the CI as I do not have permission to do that. |
4 participants
This rosci.py module is to enable test infra for ROSCI targeting live camera testing.