Fix argument names (_usb_port_id and _device_type)#3421
Merged
Nir-Az merged 1 commit intorealsenseai:ros2-developmentfrom Aug 21, 2025
Merged
Conversation
|
Can one of the admins verify this patch? |
Collaborator
|
@ynyBonfennil thanks for the PR. Thanks |
ashrafk93
approved these changes
Aug 18, 2025
Collaborator
|
@ynyBonfennil can you please follow our guidelines and base + target the change on ros2-development so we can merge it? |
Author
|
Okay, my mistake. I'll fix it. |
ynyBonfennil
force-pushed
the
fix/usb-port-id-device-type-argument-name
branch
from
d795893 to
f115056
Compare
ynyBonfennil
force-pushed
the
fix/usb-port-id-device-type-argument-name
branch
from
f115056 to
159c8fc
Compare
Author
|
@Nir-Az I rebased the branch to ros2-development. Could you check it? |
Nir-Az
approved these changes
Aug 21, 2025
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #3420
realsense2_camera node's parameter
usb_port_idanddevice_typewere renamed to_usb_port_idand_device_typeat 09e9f8e, but this update contradicts with README.md and also loses backward compatibility, so this PR renames them back to the original.