Skip to content

Conversation

ciiay
Copy link
Member

@ciiay ciiay commented Sep 5, 2025

Description

Please explain the changes you made here.

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

image

Copy link

openshift-ci bot commented Sep 5, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign gustavolira for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

dynamicRoutes:
- path: /extensions/catalog
- path: /marketplace
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to move away from the "marketplace" keyword usage (See: https://issues.redhat.com/browse/RHIDP-8299)

path: marketplace
title: Catalog
- mountPoint: application/provider
importName: InstallationContextProvider
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you get rid of this mount point and handle the installed plugins context by wrapping the DynamicMarketplacePluginRouter component with a context provider (See comment section here https://issues.redhat.com/browse/RHIDP-8301)

This Context provider keeps track of plugins that are installed/updated/enabled/disabled to list them on the catalog page alert.

@ciiay ciiay force-pushed the rhidp-8301-remove-dynamic-plugins-info-plugin branch from e447674 to 5f70157 Compare September 9, 2025 01:04
Copy link
Contributor

github-actions bot commented Sep 9, 2025

Copy link

openshift-ci bot commented Sep 9, 2025

@ciiay: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-tests 0370974 link true /test e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Member

@christoph-jerolimov christoph-jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change looks unnecessary to me, but maybe I'm wrong.

And can we merge this without updating the marketplace? I think it would great to remove the dynamic-plugins-info plugin when also update the marketplace that includes this feature (tab)

@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants