-
Notifications
You must be signed in to change notification settings - Fork 201
fix(marketplace): remove dynamic-plugins-info plugins #3366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix(marketplace): remove dynamic-plugins-info plugins #3366
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
529e0cb
to
c43f99c
Compare
dynamic-plugins.default.yaml
Outdated
dynamicRoutes: | ||
- path: /extensions/catalog | ||
- path: /marketplace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want to move away from the "marketplace" keyword usage (See: https://issues.redhat.com/browse/RHIDP-8299)
dynamic-plugins.default.yaml
Outdated
path: marketplace | ||
title: Catalog | ||
- mountPoint: application/provider | ||
importName: InstallationContextProvider |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you get rid of this mount point and handle the installed plugins context by wrapping the DynamicMarketplacePluginRouter
component with a context provider (See comment section here https://issues.redhat.com/browse/RHIDP-8301)
This Context provider keeps track of plugins that are installed/updated/enabled/disabled to list them on the catalog page alert.
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
e447674
to
5f70157
Compare
Signed-off-by: Yi Cai <[email protected]>
The image is available at: |
@ciiay: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One change looks unnecessary to me, but maybe I'm wrong.
And can we merge this without updating the marketplace? I think it would great to remove the dynamic-plugins-info plugin when also update the marketplace that includes this feature (tab)
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Description
Please explain the changes you made here.
Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer