-
Notifications
You must be signed in to change notification settings - Fork 201
chore(marketplace): remove catalog and scaffolder integration collections #3436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3096eb4
to
e36ad14
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please also remove the files from here: https://github.com/redhat-developer/rhdh/blob/main/catalog-entities/marketplace/plugins/all.yaml
The image is available at: |
sure, will remove it |
b657961
to
72bf88a
Compare
The image is available at: |
@kadel: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
This PR removes
catalog-integrations.yaml
andscaffolder-integrations.yaml
from the catalog.They were just a collection of package that are never used together.
Each package is already in the catalog as a separate entity.
Here is a small LLM generated script I used to that checks if all the packages in the integrations files have a corresponding individual plugin file.
Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer