Skip to content

Conversation

@dantovska
Copy link
Contributor

@dantovska dantovska commented Dec 15, 2025

What

Fixes the identifier field being cut off in the "Create new index" form. The field was scrollable but not entirely visible, creating poor UX.

This is a regression from RI-7762 where forms were made to expand vertically, which caused the identifier field to be cut off at the bottom.

Changes

  • Removed unused Spacer import (linter fix)

Testing

  1. Open database instance
  2. Choose search by values or keys
  3. Click "Select Index → Create new index"
  4. Add multiple identifier fields (5+)
  5. Scroll to the bottom
  6. Verify the last identifier field is fully visible
Before After
image image

Closes #RI-7873
Related: #RI-7762


Note

Adjusts layout and scrolling in the Create Index panel to prevent the last identifier field from being cut off, with minor spacing and header tweaks.

  • Create Index UI/layout:
    • Set min-height: 100% for ItemsWrapper in add-multiple-fields/AddMultipleFields.styles.ts.
    • Enhance scroll area in CreateRedisearchIndex StyledContent (adds scrollbar-width: thin).
    • Tweak spacing: reduce gaps (xll), increase separator margin (HorizontalRule sm), and wrap AddMultipleFields content in a div.
    • Simplify header structure in CreateRedisearchIndexWrapper: move Spacer, add gap="xl", and use larger separator (HorizontalRule margin l).

Written by Cursor Bugbot for commit ab5017b. This will update automatically on new commits. Configure here.

…form

Add padding-bottom to StyledContent to ensure the last identifier field
is fully visible when scrolled to the bottom. Also add explicit flex
properties to wrapper to ensure proper height constraints.

This fixes a regression introduced by RI-7762 where forms were made
to expand vertically, causing the identifier field to be cut off.

References: #RI-7873
@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2025

Code Coverage - Frontend unit tests

St.
Category Percentage Covered / Total
🟢 Statements 82.85% 21094/25462
🟡 Branches 68.05% 8881/13051
🟡 Functions 78.04% 5782/7409
🟢 Lines 83.24% 20658/24817

Test suite run success

5486 tests passing in 704 suites.

Report generated by 🧪jest coverage report action from ab5017b

valkirilov
valkirilov previously approved these changes Dec 16, 2025
… instead of component

- Change IdentifierInfo from component usage to function call
- Prevents React from unmounting/remounting on every render
- Fixes tooltip losing hover/open state
@dantovska dantovska merged commit b357741 into release/3.0.1 Dec 16, 2025
16 checks passed
@dantovska dantovska deleted the fe/bugfix/RI-7873-fix-create-index-id-layout branch December 16, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants