Repository navigation
Fix/cluster stuck in close #2217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+168
−1
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
ac39fb2
Specify issue details in ISSUE.md
Duwab bb2c124
Test failing reconnect after node end
Duwab e284166
fix(cluster): finish closing when connect() is aborted during startup…
Duwab d2ba788
Update ISSUE details
Duwab 141501c
Document where the issue comes from
Duwab 789865b
Clarify testing logic
Duwab ea1445b
Remove issue report
Duwab 3b3c509
fix(cluster): settle ready-delayed callbacks when connect() is aborted
Duwab File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(cluster): finish closing when connect() is aborted during startup…
… node resolution When the status changes while connect() is resolving the startup nodes, connect() rejects before its "close" listeners are attached and with an empty pool, so nothing moves the cluster out of "close" or "disconnecting". Handle that case explicitly so the cluster reconnects or emits "end", and pending commands are rejected.
- Loading branch information
commit e284166092ddab4e77c8080749844a086c31ff91
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.