Skip to content

fix(cluster): handle connection errors by reconnection - #762

Merged
luin merged 1 commit into
masterfrom
fix/exception-when-connecting
Dec 16, 2018
Merged

luin merged 1 commit into
masterfrom
fix/exception-when-connecting

Conversation

@luin

@luin luin commented Dec 12, 2018 •

Copy link
Copy Markdown
Collaborator

Closes #753.

Previously, exceptions caused by DNS resolving will not trigger any reconnections and fail silently. That makes errors much harder to be handled. This fix catches these exceptions and triggers a reconnection to keep the same behaviors as v3.

@luin
luin requested a review from AVVS December 12, 2018 16:38
@luin
luin merged commit 21138af into master Dec 16, 2018
@luin
luin deleted the fix/exception-when-connecting branch December 16, 2018 14:30
ioredis-robot pushed a commit that referenced this pull request Dec 16, 2018
## [4.3.1](v4.3.0...v4.3.1) (2018-12-16)

### Bug Fixes

* **cluster:** handle connection errors by reconnection ([#762](#762)) ([21138af](21138af)), closes [#753](#753)
@ioredis-robot

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 4.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

SeniorDev-99 added a commit to SeniorDev-99/ioredis that referenced this pull request Jan 12, 2026
## [4.3.1](redis/ioredis@v4.3.0...v4.3.1) (2018-12-16)

### Bug Fixes

* **cluster:** handle connection errors by reconnection ([#762](redis/ioredis#762)) ([21138af](redis/ioredis@21138af)), closes [#753](redis/ioredis#753)
MasterDev-99 added a commit to MasterDev-99/ioredis that referenced this pull request Jan 14, 2026
## [4.3.1](redis/ioredis@v4.3.0...v4.3.1) (2018-12-16)

### Bug Fixes

* **cluster:** handle connection errors by reconnection ([#762](redis/ioredis#762)) ([21138af](redis/ioredis@21138af)), closes [#753](redis/ioredis#753)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clarify cluster connection behaviour and error handling

2 participants