Support Redis 8 vector sets #4169 #4203

ggivo · 2025-07-17T13:16:19Z

Pull Request Overview

Adds support for Redis 8 vector set commands across unified, pooled, and cluster clients, including new test coverage and API interfaces.

Introduces vector set test utilities and base test classes (VectorTestUtils, VectorSetCommandsTestBase, ExtendedVectorSetCommandsTestBase).
Adds new command interfaces for vector sets (VectorSetCommands, VectorSetBinaryCommands, VectorSetPipelineCommands, VectorSetPipelineBinaryCommands) and integrates them into existing pipelines and Jedis command surfaces.
Updates pooled and cluster test classes to use a shared createTestClient pattern and remove manual tear-down logic.

Closes #4169

Add support for - VRANDMEMBER - vlinks - vrem - vemb - vcard - vadd - vsim - vdim

Copilot

Pull Request Overview

Adds support for Redis 8 vector set commands across unified, pooled, and cluster clients, including new test coverage and API interfaces.

Introduces vector set test utilities and base test classes (VectorTestUtils, VectorSetCommandsTestBase, ExtendedVectorSetCommandsTestBase).
Adds new command interfaces for vector sets (VectorSetCommands, VectorSetBinaryCommands, VectorSetPipelineCommands, VectorSetPipelineBinaryCommands) and integrates them into existing pipelines and Jedis command surfaces.
Updates pooled and cluster test classes to use a shared createTestClient pattern and remove manual tear-down logic.

Reviewed Changes

Copilot reviewed 51 out of 51 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/main/java/redis/clients/jedis/commands/VectorSetCommands.java	New interface for core vector set commands
src/main/java/redis/clients/jedis/commands/VectorSetBinaryCommands.java	New interface for binary vector set commands
src/main/java/redis/clients/jedis/commands/VectorSetPipelineCommands.java	New pipeline interface for vector set commands
src/main/java/redis/clients/jedis/commands/VectorSetPipelineBinaryCommands.java	New pipeline interface for binary vector set commands
src/main/java/redis/clients/jedis/commands/PipelineCommands.java	Added `VectorSetPipelineCommands`
src/main/java/redis/clients/jedis/commands/PipelineBinaryCommands.java	Added `VectorSetPipelineBinaryCommands`
src/main/java/redis/clients/jedis/commands/JedisCommands.java	Added `VectorSetCommands`
src/main/java/redis/clients/jedis/commands/JedisBinaryCommands.java	Added `VectorSetBinaryCommands`
src/test/java/redis/clients/jedis/commands/unified/VectorTestUtils.java	Utility for FP32 <→ float conversions in tests
src/test/java/redis/clients/jedis/commands/unified/VectorSetCommandsTestBase.java	Core integration tests for all vector set commands
src/test/java/redis/clients/jedis/commands/unified/ExtendedVectorSetCommandsTestBase.java	Extended sample tests based on Redis documentation
src/test/java/redis/clients/jedis/commands/unified/pipelined/*	Updated pooled tests to use `createTestClient` pattern
src/test/java/redis/clients/jedis/commands/unified/cluster/*	Updated cluster tests to use `createTestClient`
src/test/java/redis/clients/jedis/commands/unified/UnifiedJedisCommandsTestBase.java	Added abstract `createTestClient` and lifecycle hooks
src/test/java/redis/clients/jedis/commands/unified/StreamsBinaryCommandsTestBase.java	Removed unused `setUpTestClient` stub before streams

Comments suppressed due to low confidence (1)

src/test/java/redis/clients/jedis/commands/unified/VectorSetCommandsTestBase.java:199

The noQuantParams variable is mistakenly initialized with .q8(). It should use .noQuant() to test the NOQUANT quantization scenario.

    VAddParams quantParams = new VAddParams().q8();

src/test/java/redis/clients/jedis/commands/unified/VectorSetCommandsTestBase.java

- Add integration test for Jedis client

atakavci

LGTM!
just a few nits.

src/main/java/redis/clients/jedis/BuilderFactory.java

src/main/java/redis/clients/jedis/CommandObjects.java

- remove duplicated DOUBLE_LIST - reduce code duplication

atakavci

LGTM

src/test/java/redis/clients/jedis/commands/unified/StreamsBinaryCommandsTestBase.java

src/test/resources/env/.env

src/main/java/redis/clients/jedis/params/VSimParams.java

uglide

LGTM

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [redis.clients:jedis](https://github.com/redis/jedis) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `6.1.0` -> `6.2.0` | | [com.google.cloud:google-cloud-spanner](https://github.com/googleapis/java-spanner) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `6.98.1` -> `6.99.0` | --- ### Release Notes <details> <summary>redis/jedis (redis.clients:jedis)</summary> ### [`v6.2.0`](https://github.com/redis/jedis/releases/tag/v6.2.0): 6.2.0 ### Changes #### 🚀 New Features - \[vector sets] Support for VSIM WITHATTRIBS (CAE-1421) ([#4260](redis/jedis#4260)) - Support Redis 8 vector sets [#4169](redis/jedis#4169) ([#4203](redis/jedis#4203)) #### 🐛 Bug Fixes - Fix JedisBroadcastException in functionLoadReplace for Redis Cluster ([#4219](redis/jedis#4219)) #### 🧰 Maintenance - Bump org.apache.maven.plugins:maven-javadoc-plugin from 3.11.2 to 3.11.3 ([#4246](redis/jedis#4246)) - Bump org.junit:junit-bom from 5.13.3 to 5.13.4 ([#4216](redis/jedis#4216)) - docs: Improve Javadoc for HostAndPortMapper ([#4112](redis/jedis#4112)) ([#4227](redis/jedis#4227)) #### Contributors We'd like to thank all the contributors who worked on this release! [@JuneYub](https://github.com/JuneYub), [@Kguswo](https://github.com/Kguswo), [@dependabot](https://github.com/dependabot), [@dependabot](https://github.com/dependabot)\[bot] and [@ggivo](https://github.com/ggivo) </details> <details> <summary>googleapis/java-spanner (com.google.cloud:google-cloud-spanner)</summary> ### [`v6.99.0`](https://github.com/googleapis/java-spanner/blob/HEAD/CHANGELOG.md#6990-2025-08-26) ##### Features - Support read lock mode for R/W transactions ([#4010](googleapis/java-spanner#4010)) ([7d752d6](googleapis/java-spanner@7d752d6)) ##### Bug Fixes - **deps:** Update the Java code generator (gapic-generator-java) to 2.62.0 ([52c68db](googleapis/java-spanner@52c68db)) - GetCommitResponse() should return error if tx has not committed ([#4021](googleapis/java-spanner#4021)) ([a2c179f](googleapis/java-spanner@a2c179f)) ##### Dependencies - Update dependency com.google.cloud:sdk-platform-java-config to v3.52.0 ([#4024](googleapis/java-spanner#4024)) ([7e3294f](googleapis/java-spanner@7e3294f)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 9d031eaaab2d726402884bd41681c856931f12f0

ggivo added 13 commits July 15, 2025 15:01

Initial vector set commit

eaf4bce

Add support for - VRANDMEMBER - vlinks - vrem - vemb - vcard - vadd - vsim - vdim

Add UnifiedJedis vadd integration tests

ea9e47a

Add support for reduce dim in vadd

f153e72

Add support for vgetattr

41490ee

Add support for vsetattr

608f78c

Add support for vinfo

54708ca

Add VDIM, VCARD integration test

d7d8e85

Add VEMB integration test

f493547

Add VSETATTR/VGETATTR integration test

9a141d5

Add VLINKS integration test

caceeff

Add VRANDMEMBER integration test

1b63d34

Add VREM integration test

a0fab23

Add VSIM integration test & refactor

80ad09b

ggivo requested a review from Copilot July 17, 2025 13:16

ggivo marked this pull request as draft July 17, 2025 13:18

Copilot AI reviewed Jul 17, 2025

View reviewed changes

src/test/java/redis/clients/jedis/commands/unified/VectorSetCommandsTestBase.java Outdated Show resolved Hide resolved

ggivo added 5 commits July 17, 2025 16:30

cleanup

7e70773

add missing RawVector

dad863a

fix failing tests

8fcc5a8

fix PooledExtendedVectorSetCommandsTest

5262e8f

mark vector-set api as Experimental

0ac4ad8

- Add integration test for Jedis client

ggivo force-pushed the feature/vector-set branch from 6e0e51e to 0ac4ad8 Compare July 18, 2025 08:57

Fix tests

299c7ec

ggivo marked this pull request as ready for review July 18, 2025 11:48

ggivo requested review from uglide, tishun and atakavci July 18, 2025 11:49

clean up

5f74f97

atakavci previously approved these changes Jul 22, 2025

View reviewed changes

src/main/java/redis/clients/jedis/BuilderFactory.java Outdated Show resolved Hide resolved

src/main/java/redis/clients/jedis/CommandObjects.java Show resolved Hide resolved

src/main/java/redis/clients/jedis/CommandObjects.java Show resolved Hide resolved

Address review comments

b6f3f8d

- remove duplicated DOUBLE_LIST - reduce code duplication

ggivo dismissed atakavci’s stale review via b6f3f8d July 23, 2025 09:40

Merge branch 'master' into feature/vector-set

9a42d4e

atakavci previously approved these changes Jul 23, 2025

View reviewed changes

ggivo added the feature label Jul 23, 2025

ggivo added this to the 6.1.0 milestone Jul 23, 2025

ggivo added the ready to merge label Jul 23, 2025

Merge branch 'master' into feature/vector-set

2f80150

ggivo dismissed atakavci’s stale review via 2f80150 July 25, 2025 15:42

ggivo added 2 commits July 25, 2025 19:26

fix tests after merge conflict is resolved

c0d44de

format new files

d344458

ggivo modified the milestones: 6.1.0, 7.0.0 Aug 5, 2025

uglide requested changes Aug 12, 2025

View reviewed changes

src/test/java/redis/clients/jedis/commands/unified/StreamsBinaryCommandsTestBase.java Show resolved Hide resolved

src/test/resources/env/.env Outdated Show resolved Hide resolved

src/main/java/redis/clients/jedis/params/VSimParams.java Show resolved Hide resolved

ggivo removed the ready to merge label Aug 13, 2025

ggivo added 3 commits August 13, 2025 08:03

Merge branch 'master' into feature/vector-set

a537d2c

Add EPSILON parameter

a6b4968

fix errors in javadocs (java 8)

7df889d

ggivo modified the milestones: 7.0.0, 6.2.0 Aug 13, 2025

ggivo requested a review from uglide August 13, 2025 12:53

Merge branch 'master' into feature/vector-set

68fc925

uglide previously approved these changes Aug 14, 2025

View reviewed changes

Merge branch 'master' into feature/vector-set

2fa50ff

ggivo dismissed uglide’s stale review via 2fa50ff August 14, 2025 16:30

fix errors after rebase

a285848

ggivo merged commit affb536 into redis:master Aug 14, 2025
13 of 14 checks passed

ggivo deleted the feature/vector-set branch August 14, 2025 17:15

tishun mentioned this pull request Oct 1, 2025

Align the VectorSet API with other clients redis/lettuce#3459

Open

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Support Redis 8 vector sets #4169 #4203

Support Redis 8 vector sets #4169 #4203

Uh oh!

ggivo commented Jul 17, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

atakavci left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

atakavci left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

uglide left a comment

Uh oh!

Uh oh!

Uh oh!

Support Redis 8 vector sets #4169 #4203

Support Redis 8 vector sets #4169 #4203

Uh oh!

Conversation

ggivo commented Jul 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

atakavci left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

atakavci left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

uglide left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ggivo commented Jul 17, 2025 •

edited

Loading