Skip to content

Moved self._lock initialisation to Pool constructor #3473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vladvildanov merged 4 commits into from
Jan 6, 2025
Merged

Moved self._lock initialisation to Pool constructor #3473

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d000b16
Moved self._lock initialisation to Pool constructor
vladvildanov Jan 6, 2025
f2e590d
Added test case
vladvildanov Jan 6, 2025
22609a2
Codestyle fixes
vladvildanov Jan 6, 2025
c3f964a
Added correct annotations
vladvildanov Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Added correct annotations
  • Loading branch information
@vladvildanov
vladvildanov committed Jan 6, 2025
commit c3f964a6f48895f453fea99b359fcf3ff26f73d9
15 changes: 12 additions & 3 deletions tests/test_connection_pool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,14 @@
import redis
from redis.cache import CacheConfig
from redis.connection import CacheProxyConnection, Connection, to_bool
from redis.utils import SSL_AVAILABLE

from .conftest import _get_client, skip_if_redis_enterprise, skip_if_server_version_lt
from redis.utils import HIREDIS_AVAILABLE, SSL_AVAILABLE

from .conftest import (
_get_client,
skip_if_redis_enterprise,
skip_if_resp_version,
skip_if_server_version_lt,
)
from .test_pubsub import wait_for_message


Expand Down Expand Up @@ -197,6 +202,10 @@ def test_repr_contains_db_info_unix(self):
expected = "path=abc,db=0,client_name=test-client"
assert expected in repr(pool)

@pytest.mark.skipif(HIREDIS_AVAILABLE, reason="PythonParser only")
@pytest.mark.onlynoncluster
@skip_if_resp_version(2)
@skip_if_server_version_lt("7.4.0")
def test_initialise_pool_with_cache(self, master_host):
pool = redis.BlockingConnectionPool(
connection_class=Connection,
Expand Down
Loading