No need for a 2nd destructuring and delete
#9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we're already using destructuring here, we can skip the 2nd destructuring step and the `delete` (in order to avoid possible deoptimization of the function)
johanneslumpe
changed the title
deletedelete
erikras
added a commit
that referenced
this pull request
Aug 4, 2015
No need for a 2nd destructuring and `delete`
Member
|
Very nice!! |
Contributor
Author
|
argh |
Contributor
Author
|
it has a typo |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we're already using destructuring here, we can skip the 2nd destructuring step and the
delete(in order to avoid possible deoptimization of the function)