Skip to content

Rewrite Subscription as a closure factory for byte shaving #1755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markerikson merged 4 commits into from
Jul 6, 2021
Merged

Rewrite Subscription as a closure factory for byte shaving #1755

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
de49c87
Rewrite Subscription as a closure factory for byte shaving
markerikson Jul 5, 2021
ed40ee6
Work around annoying Babel "loose" warning
markerikson Jul 6, 2021
e89a0dd
Switch back to simpler bindActionCreators implementation
markerikson Jul 6, 2021
20a2394
Try tweaking Babel to make this loose error stop
markerikson Jul 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Switch back to simpler bindActionCreators implementation
  • Loading branch information
@markerikson
markerikson committed Jul 6, 2021
commit e89a0ddbb7e97bcbdfb1524866bf0594a53a0609
24 changes: 3 additions & 21 deletions src/utils/bindActionCreators.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,28 +1,10 @@
import {
ActionCreator,
ActionCreatorsMapObject,
AnyAction,
Dispatch,
} from 'redux'

function bindActionCreator<A extends AnyAction = AnyAction>(
actionCreator: ActionCreator<A>,
dispatch: Dispatch
) {
return function (this: any, ...args: any[]) {
return dispatch(actionCreator.apply(this, args))
}
}
import { ActionCreatorsMapObject, Dispatch } from 'redux'

export default function bindActionCreators(
actionCreators: ActionCreator<any> | ActionCreatorsMapObject,
actionCreators: ActionCreatorsMapObject,
dispatch: Dispatch
) {
if (typeof actionCreators === 'function') {
return bindActionCreator(actionCreators, dispatch)
}

const boundActionCreators: ActionCreatorsMapObject = {}
const boundActionCreators: ActionCreatorsMapObject<any> = {}
for (const key in actionCreators) {
const actionCreator = actionCreators[key]
if (typeof actionCreator === 'function') {
Expand Down