Remove state between connectAdvanced calls in example #685
+0
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I saw this example I was initially excited by the prospect of storing `state` between `connectAdvanced` calls. I thought of the uses like storing the deleted todo items, or even just the count. But then it dawned on me that the idiomatic approach to Redux, such as the ability for time travel - is challenged when the previous state is stored. For newbies like myself, suggesting this in documentation can be misleading and might encourage the wrong practice.
|
Well, it's not used there anyways, so that's OK to remove. Thanks! |
josepot
pushed a commit
to josepot/react-redux-lean
that referenced
this pull request
Sep 21, 2018
When I saw this example I was initially excited by the prospect of storing `state` between `connectAdvanced` calls. I thought of the uses like storing the deleted todo items, or even just the count. But then it dawned on me that the idiomatic approach to Redux, such as the ability for time travel - is challenged when the previous state is stored. For newbies like myself, suggesting this in documentation can be misleading and might encourage the wrong practice.
albertodev7
pushed a commit
to albertodev7/react-redux
that referenced
this pull request
Dec 8, 2022
When I saw this example I was initially excited by the prospect of storing `state` between `connectAdvanced` calls. I thought of the uses like storing the deleted todo items, or even just the count. But then it dawned on me that the idiomatic approach to Redux, such as the ability for time travel - is challenged when the previous state is stored. For newbies like myself, suggesting this in documentation can be misleading and might encourage the wrong practice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I saw this example I was initially excited by the prospect of storing
statebetweenconnectAdvancedcalls.I thought of the uses like storing the deleted todo items, or even just the count. But then it dawned on me that the idiomatic approach to Redux, such as the ability for time travel - is challenged when the previous state is stored. For example if I stored
deletedTodoCountand then used time travel this figure would be wrong because the previous state would be from the future.For newbies like myself, suggesting this in documentation can be misleading and might encourage the wrong practice of depending on the difference between states for props when really should come from the store.