Skip to content

Format all files #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 17, 2024
Merged

Format all files #369

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6444c30
Bump `prettier`
aryaemami59 Mar 21, 2024
9114e68
Remove `trailingComma` option from `.prettierrc.json`
aryaemami59 Mar 21, 2024
01a1e95
Run Prettier on all files
aryaemami59 Mar 21, 2024
9f7ed54
Merge branch 'master' of https://github.com/reduxjs/redux-thunk into …
aryaemami59 Mar 22, 2024
3c42ec2
Bump Prettier to version 3.3.2
aryaemami59 Jun 24, 2024
8ad0f9f
Merge branch 'master' of https://github.com/reduxjs/redux-thunk into …
aryaemami59 Jul 12, 2024
ed61c30
Bump Prettier to version 3.3.3
aryaemami59 Jul 16, 2024
a2a020a
Merge branch 'master' of https://github.com/reduxjs/redux-thunk into …
aryaemami59 Aug 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove trailingComma option from .prettierrc.json
  • Loading branch information
@aryaemami59
aryaemami59 committed Mar 21, 2024
commit 9114e684dda6dd1e64b91f69e936f49deb702506
1 change: 0 additions & 1 deletion .prettierrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,5 @@
"semi": false,
"singleQuote": true,
"tabWidth": 2,
"trailingComma": "none",
Copy link
Member

@timdorr timdorr Mar 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the vast majority of changes are related to this config change. What's the motivation? Just asking in case we can keep this to a less extensive set of changes.

Copy link
Member Author

@aryaemami59 aryaemami59 Mar 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Staying consistent with the other repos. Since the plan was to eventually unify all their configs by having them use the shareable configs created in reduxjs/redux-toolkit#4138, I thought taking care of line endings/formatting issues in one PR would make things less unpredictable so you guys won't have to deal with a bunch of formatting changes in an unrelated PR in case somebody decides to run Prettier before pushing their changes.

"arrowParens": "avoid"
}