Remove unused ESLint disable directives

packages/toolkit/src/createAsyncThunk.ts

@@ -61,7 +61,7 @@ export interface SerializedError {
   code?: string
 }
 
-const commonProperties: Array<keyof SerializedError> = [
+const commonProperties: (keyof SerializedError)[] = [
   'name',
   'message',
   'stack',
@@ -644,7 +644,6 @@ export const createAsyncThunk = /* @__PURE__ */ (() => {
             }
 
             if (conditionResult === false || abortController.signal.aborted) {
-              // eslint-disable-next-line no-throw-literal
               throw {
                 name: 'ConditionError',
                 message: 'Aborted due to condition callback returning false.',

packages/toolkit/src/createSlice.ts

@@ -114,7 +114,7 @@ export interface Slice<
    * Equivalent to `slice.getSelectors((state: RootState) => state[slice.reducerPath])`.
    */
   get selectors(): Id<
-    SliceDefinedSelectors<State, Selectors, { [K in ReducerPath]: State }>
+    SliceDefinedSelectors<State, Selectors, Record<ReducerPath, State>>
   >
 
   /**
@@ -136,7 +136,7 @@ export interface Slice<
    *
    * Will throw an error if slice is not found.
    */
-  selectSlice(state: { [K in ReducerPath]: State }): State
+  selectSlice(state: Record<ReducerPath, State>): State
 }
 
 /**
@@ -175,7 +175,7 @@ type InjectedSlice<
     SliceDefinedSelectors<
       State,
       Selectors,
-      { [K in ReducerPath]?: State | undefined }
+      Partial<Record<ReducerPath, State | undefined>>
     >
   >
 
@@ -184,7 +184,7 @@ type InjectedSlice<
    *
    * Returns initial state if slice is not found.
    */
-  selectSlice(state: { [K in ReducerPath]?: State | undefined }): State
+  selectSlice(state: Partial<Record<ReducerPath, State | undefined>>): State
 }
 
 /**
@@ -423,9 +423,10 @@ export type SliceCaseReducers<State> =
 /**
  * The type describing a slice's `selectors` option.
  */
-export type SliceSelectors<State> = {
-  [K: string]: (sliceState: State, ...args: any[]) => any
-}
+export type SliceSelectors<State> = Record<
+  string,
+  (sliceState: State, ...args: any[]) => any
+>
 
 type SliceActionType<
   SliceName extends string,
@@ -747,7 +748,7 @@ export function buildCreateSlice({ creators }: BuildCreateSliceConfig = {}) {
       Slice<State, CaseReducers, Name, CurrentReducerPath, Selectors>,
       'getSelectors' | 'selectors' | 'selectSlice' | 'reducerPath'
     > {
-      function selectSlice(state: { [K in CurrentReducerPath]: State }) {
+      function selectSlice(state: Record<CurrentReducerPath, State>) {
         let sliceState = state[reducerPath]
         if (typeof sliceState === 'undefined') {
           if (injected) {

packages/toolkit/src/entities/tests/sorted_state_adapter.test.ts

@@ -21,7 +21,6 @@ describe('Sorted State Adapter', () => {
   let state: EntityState<BookModel, string>
 
   beforeAll(() => {
-    //eslint-disable-next-line
     Object.defineProperty(Array.prototype, 'unwantedField', {
       enumerable: true,
       configurable: true,

packages/toolkit/src/entities/tests/unsorted_state_adapter.test.ts

@@ -1,20 +1,19 @@
-import type { EntityAdapter, EntityState } from '../models'
+import { createNextState } from '../..'
 import { createEntityAdapter } from '../create_adapter'
+import type { EntityAdapter, EntityState } from '../models'
 import type { BookModel } from './fixtures/book'
 import {
   AClockworkOrange,
   AnimalFarm,
   TheGreatGatsby,
   TheHobbit,
 } from './fixtures/book'
-import { createNextState } from '../..'
 
 describe('Unsorted State Adapter', () => {
   let adapter: EntityAdapter<BookModel, string>
   let state: EntityState<BookModel, string>
 
   beforeAll(() => {
-    //eslint-disable-next-line
     Object.defineProperty(Array.prototype, 'unwantedField', {
       enumerable: true,
       configurable: true,
@@ -293,9 +292,9 @@ describe('Unsorted State Adapter', () => {
         entities: { b: { id: 'b', title: 'First' }, c: { id: 'c' } }
       }
       We now expect that only 'c' will be left:
-      { 
-        ids: [ 'c' ], 
-        entities: { c: { id: 'c', title: 'First' } } 
+      {
+        ids: [ 'c' ],
+        entities: { c: { id: 'c', title: 'First' } }
       }
     */
     expect(ids.length).toBe(1)

packages/toolkit/src/entities/unsorted_state_adapter.ts

@@ -102,7 +102,7 @@ export function createUnsortedStateAdapter<T, Id extends EntityId>(
   }
 
   function takeNewKey(
-    keys: { [id: string]: Id },
+    keys: Record<string, Id>,
     update: Update<T, Id>,
     state: R,
   ): boolean {
@@ -129,12 +129,12 @@ export function createUnsortedStateAdapter<T, Id extends EntityId>(
   }
 
   function updateManyMutably(
-    updates: ReadonlyArray<Update<T, Id>>,
+    updates: readonly Update<T, Id>[],
     state: R,
   ): void {
-    const newKeys: { [id: string]: Id } = {}
+    const newKeys: Record<string, Id> = {}
 
-    const updatesPerEntity: { [id: string]: Update<T, Id> } = {}
+    const updatesPerEntity: Record<string, Update<T, Id>> = {}
 
     updates.forEach((update) => {
       // Only apply updates to entities that currently exist

packages/toolkit/src/immutableStateInvariantMiddleware.ts

@@ -35,8 +35,8 @@ function trackProperties(
   isImmutable: IsImmutableFunc,
   ignorePaths: IgnorePaths = [],
   obj: Record<string, any>,
-  path: string = '',
-  checkedObjects: Set<Record<string, any>> = new Set(),
+  path = '',
+  checkedObjects = new Set<Record<string, any>>(),
 ) {
   const tracked: Partial<TrackedProperty> = { value: obj }
 
@@ -66,8 +66,8 @@ function detectMutations(
   ignoredPaths: IgnorePaths = [],
   trackedProperty: TrackedProperty,
   obj: any,
-  sameParentRef: boolean = false,
-  path: string = '',
+  sameParentRef = false,
+  path = '',
 ): { wasMutated: boolean; path?: string } {
   const prevObj = trackedProperty ? trackedProperty.value : undefined
 

packages/toolkit/src/query/core/buildThunks.ts

@@ -39,6 +39,11 @@ import {
   isQueryDefinition,
 } from '../endpointDefinitions'
 import { HandledError } from '../HandledError'
+import {
+  NamedSchemaError,
+  parseWithSchema,
+  shouldSkip,
+} from '../standardSchema'
 import type { UnwrapPromise } from '../tsHelpers'
 import type {
   InfiniteData,
@@ -68,11 +73,6 @@ import {
   isRejected,
   isRejectedWithValue,
 } from './rtkImports'
-import {
-  parseWithSchema,
-  NamedSchemaError,
-  shouldSkip,
-} from '../standardSchema'
 
 export type BuildThunksApiEndpointQuery<
   Definition extends QueryDefinition<any, any, any, any, any>,
@@ -391,12 +391,12 @@ export function buildThunks<
       )
     }
 
-  function addToStart<T>(items: Array<T>, item: T, max = 0): Array<T> {
+  function addToStart<T>(items: T[], item: T, max = 0): T[] {
     const newItems = [item, ...items]
     return max && newItems.length > max ? newItems.slice(0, -1) : newItems
   }
 
-  function addToEnd<T>(items: Array<T>, item: T, max = 0): Array<T> {
+  function addToEnd<T>(items: T[], item: T, max = 0): T[] {
     const newItems = [...items, item]
     return max && newItems.length > max ? newItems.slice(1) : newItems
   }
@@ -509,7 +509,7 @@ export function buildThunks<
       endpointDefinition
 
     try {
-      let transformResponse: TransformCallback = defaultTransformResponse
+      const transformResponse: TransformCallback = defaultTransformResponse
 
       const baseQueryApi = {
         signal,
@@ -786,7 +786,7 @@ export function buildThunks<
     } catch (error) {
       let caughtError = error
       if (caughtError instanceof HandledError) {
-        let transformErrorResponse = getTransformCallbackForEndpoint(
+        const transformErrorResponse = getTransformCallbackForEndpoint(
           endpointDefinition,
           'transformErrorResponse',
         )
@@ -999,7 +999,7 @@ In the case of an unhandled error, no tags will be "provided" or "invalidated".`
       const force = hasTheForce(options) && options.force
       const maxAge = hasMaxAge(options) && options.ifOlderThan
 
-      const queryAction = (force: boolean = true) => {
+      const queryAction = (force = true) => {
         const options = { forceRefetch: force, isPrefetch: true }
         return (
           api.endpoints[endpointName] as ApiEndpointQuery<any, any>

packages/toolkit/src/query/core/module.ts

@@ -100,7 +100,6 @@ export type CoreModule =
 export type ThunkWithReturnValue<T> = ThunkAction<T, any, any, UnknownAction>
 
 export interface ApiModules<
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   BaseQuery extends BaseQueryFn,
   Definitions extends EndpointDefinitions,
   ReducerPath extends string,
@@ -216,9 +215,10 @@ export interface ApiModules<
        * See https://redux-toolkit.js.org/rtk-query/usage/server-side-rendering for details.
        */
       getRunningQueriesThunk(): ThunkWithReturnValue<
-        Array<
-          QueryActionCreatorResult<any> | InfiniteQueryActionCreatorResult<any>
-        >
+        (
+          | QueryActionCreatorResult<any>
+          | InfiniteQueryActionCreatorResult<any>
+        )[]
       >
 
       /**
@@ -230,7 +230,7 @@ export interface ApiModules<
        * See https://redux-toolkit.js.org/rtk-query/usage/server-side-rendering for details.
        */
       getRunningMutationsThunk(): ThunkWithReturnValue<
-        Array<MutationActionCreatorResult<any>>
+        MutationActionCreatorResult<any>[]
       >
 
       /**
@@ -371,7 +371,7 @@ export interface ApiModules<
        * ```
        */
       invalidateTags: ActionCreatorWithPayload<
-        Array<TagDescription<TagTypes> | null | undefined>,
+        (TagDescription<TagTypes> | null | undefined)[],
         string
       >
 
@@ -382,12 +382,12 @@ export interface ApiModules<
        */
       selectInvalidatedBy: (
         state: RootState<Definitions, string, ReducerPath>,
-        tags: ReadonlyArray<TagDescription<TagTypes> | null | undefined>,
-      ) => Array<{
+        tags: readonly (TagDescription<TagTypes> | null | undefined)[],
+      ) => {
         endpointName: string
         originalArgs: any
         queryCacheKey: string
-      }>
+      }[]
 
       /**
        * A function to select all arguments currently cached for a given endpoint.
@@ -397,7 +397,7 @@ export interface ApiModules<
       selectCachedArgsForQuery: <QueryName extends AllQueryKeys<Definitions>>(
         state: RootState<Definitions, string, ReducerPath>,
         queryName: QueryName,
-      ) => Array<QueryArgFromAnyQuery<Definitions[QueryName]>>
+      ) => QueryArgFromAnyQuery<Definitions[QueryName]>[]
     }
     /**
      * Endpoints based on the input endpoints provided to `createApi`, containing `select` and `action matchers`.
@@ -427,9 +427,7 @@ export interface ApiModules<
 }
 
 export interface ApiEndpointQuery<
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   Definition extends QueryDefinition<any, any, any, any, any>,
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   Definitions extends EndpointDefinitions,
 > extends BuildThunksApiEndpointQuery<Definition>,
     BuildInitiateApiEndpointQuery<Definition>,
@@ -442,9 +440,7 @@ export interface ApiEndpointQuery<
 }
 
 export interface ApiEndpointInfiniteQuery<
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   Definition extends InfiniteQueryDefinition<any, any, any, any, any>,
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   Definitions extends EndpointDefinitions,
 > extends BuildThunksApiEndpointInfiniteQuery<Definition>,
     BuildInitiateApiEndpointInfiniteQuery<Definition>,
@@ -456,11 +452,8 @@ export interface ApiEndpointInfiniteQuery<
   Types: NonNullable<Definition['Types']>
 }
 
-// eslint-disable-next-line @typescript-eslint/no-unused-vars
 export interface ApiEndpointMutation<
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   Definition extends MutationDefinition<any, any, any, any, any>,
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   Definitions extends EndpointDefinitions,
 > extends BuildThunksApiEndpointMutation<Definition>,
     BuildInitiateApiEndpointMutation<Definition>,

packages/toolkit/src/query/react/module.ts

@@ -37,12 +37,9 @@ export type ReactHooksModule = typeof reactHooksModuleName
 
 declare module '@reduxjs/toolkit/query' {
   export interface ApiModules<
-    // eslint-disable-next-line @typescript-eslint/no-unused-vars
     BaseQuery extends BaseQueryFn,
     Definitions extends EndpointDefinitions,
-    // eslint-disable-next-line @typescript-eslint/no-unused-vars
     ReducerPath extends string,
-    // eslint-disable-next-line @typescript-eslint/no-unused-vars
     TagTypes extends string,
   > {
     [reactHooksModuleName]: {

packages/toolkit/src/query/retry.ts

@@ -24,8 +24,8 @@ import { HandledError } from './HandledError'
  * @param maxRetries - Maximum number of retries
  */
 async function defaultBackoff(
-  attempt: number = 0,
-  maxRetries: number = 5,
+  attempt = 0,
+  maxRetries = 5,
   signal?: AbortSignal,
 ) {
   const attempts = Math.min(attempt, maxRetries)
@@ -142,7 +142,6 @@ const retryWithBackoff: BaseQueryEnhancer<
   }
   let retry = 0
 
-  // eslint-disable-next-line no-constant-condition
   while (true) {
     // Check if aborted before each attempt
     failIfAborted(api.signal)

packages/toolkit/src/query/tests/retry.test.ts

@@ -7,7 +7,7 @@ beforeEach(() => {
   vi.useFakeTimers()
 })
 
-const loopTimers = async (max: number = 12) => {
+const loopTimers = async (max = 12) => {
   let count = 0
   while (count < max) {
     await vi.advanceTimersByTimeAsync(1)

packages/toolkit/src/serializableStateInvariantMiddleware.ts

@@ -35,7 +35,7 @@ export type IgnorePaths = readonly (string | RegExp)[]
  */
 export function findNonSerializableValue(
   value: unknown,
-  path: string = '',
+  path = '',
   isSerializable: (value: unknown) => boolean = isPlain,
   getEntries?: (value: unknown) => [string, any][],
   ignoredPaths: IgnorePaths = [],

packages/toolkit/src/tests/createSlice.test.ts

@@ -406,7 +406,6 @@ describe('createSlice', () => {
           },
         },
         extraReducers(builder) {
-          // eslint-disable-next-line @typescript-eslint/no-use-before-define
           builder.addCase(second.actions.other, () => {
             return 'firstOther'
           })