Update ComputingDerivedData.md #1516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/recipes/ComputingDerivedData.md
Outdated
| In the example below `mapStateToPropsFactory` creates a new `getVisibleTodos` selector, and returns a `mapStateToProps` function that has exclusive access to the new selector: | ||
|
|
||
| ```js | ||
| const mapStateToPropsFactory = () => { |
Contributor
There was a problem hiding this comment.
I’m a bit concerned we are calling the same concept “factory” and “creator” on the same page.
Maybe we could change that to makeGetVisibleProps(), makeMapStateToProps()?
ellbee
force-pushed
the
update_computing_derived_data
branch
from
ab364c0 to
d843d4b
Compare
docs/recipes/ComputingDerivedData.md
Outdated
| export default VisibleTodoList | ||
| ``` | ||
|
|
||
| A selector created with `createSelector` only returns the cached value when its set of arguments is the same as its previous set of arguments. If we alternate between rendering `<VisibleTodoList listId="1" />` and `<VisibleTodoList listId="2" />`, the shared selector will alternate between receiving `{listId: 1}` and `{listId: 2}` as its `props` argument. This will cause the arguments to be different on each call, so the selector will always recompute instead of returning the cached value. We'll see how to overcome this limitation in the next section. |
Contributor
There was a problem hiding this comment.
Nit: can you please use ’ instead '
ellbee
force-pushed
the
update_computing_derived_data
branch
3 times, most recently
from
04e0840 to
a65b81f
Compare
docs/recipes/ComputingDerivedData.md
Outdated
| ```js | ||
| const makeMapStateToProps = () => { | ||
| const getVisibleTodos = makeGetVisibleTodos() | ||
| return (state, props) => { |
Contributor
There was a problem hiding this comment.
Can you change it here, too?
const mapStateToProps = ...
return mapStateToProps
Contributor
|
Great work. Will merge after this last nit. Thank you very much. |
ellbee
force-pushed
the
update_computing_derived_data
branch
from
a65b81f to
99f6984
Compare
docs/recipes/ComputingDerivedData.md
Outdated
| ### Motivation for Memoized Selectors | ||
|
|
||
| Let's revisit the [Todos List example](../basics/UsageWithReact.md): | ||
| > The examples in this section are based on the [Redux Todos List example](http://redux.js.org/docs/basics/UsageWithReact.html). |
Contributor
There was a problem hiding this comment.
What is the reason for this link change?
Contributor
Author
There was a problem hiding this comment.
Oh, I didn't do it on purpose, it's because of a copy paste from the reselect docs. I'll switch it back.
ellbee
force-pushed
the
update_computing_derived_data
branch
2 times, most recently
from
45acb4d to
91b03f6
Compare
ellbee
force-pushed
the
update_computing_derived_data
branch
from
91b03f6 to
a982b6f
Compare
Contributor
|
Awesome, I reckon this is ready – really useful resource! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's an update for the Computing Derived Data doc that I have been tinkering with for a couple of weeks. To be honest I found it pretty hard to write, any criticisms or suggested improvements are very welcome!