Issue 1743 #1770
Merged
Issue 1743 #1770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rename window.__INITIAL_STATE__ to window.__PRELOADED_STATE__
|
This looks good to me, any objections from other maintainers? |
|
👍 |
|
LGTM |
seantcoyote
pushed a commit
to seantcoyote/redux
that referenced
this pull request
Jan 14, 2018
* rename createStore param `initialState` to `preloadedState` * rename configureStore param `initialState` to `preloadedState` * rename `window.__INITIAL_STATE__` in examples and docs rename window.__INITIAL_STATE__ to window.__PRELOADED_STATE__
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renames
initialStateincreateStoreandconfigureStore, as well aswindow.__INITIAL_STATE__to address #1743. It doesn't touch use ofinitialStatein the reducer examples.There are a couple of comments that refer to
preloadedStateas 'initial state' that weren't addressed because I thought 'initial state' added to readability, e.g. https://github.com/reactjs/redux/compare/master...dliv:issue-1743?expand=1#diff-2b443c0a3e751858f6315977ee4a769aR85