Skip to content

resolve test package dependency duplicates #1631

@thedavidprice

Description

@thedavidprice

@peterp @Tobbe moving conversation here from #1625/comment

Outstanding Questions:

If whatwg-fetch should be removed, should we remove the other packages too? Or should whatwg-fetch only be in this top level package.json, but moved to dependencies? The top level package.json doesn't have any other deps, only devDeps. @peterp What do you think?


Original comment

@thedavidprice I noticed that too. I did dig in to it a little bit. It was added to that file by @peterp in this commit

commit da6ebb41bb02d5eaf43495726fcea0ce46397e34
Author: Peter Pistorius <[email protected]>
Date:   Sun Jun 14 14:31:26 2020 +0200

    Move testing things to global package.
diff --git a/package.json b/package.json
index 5dbbb66b..22d0ec86 100644
--- a/package.json
+++ b/package.json
@@ -16,11 +16,16 @@
     "@babel/runtime-corejs3": "^7.9.2",
     "babel-plugin-auto-import": "^1.0.5",
     "babel-plugin-module-resolver": "^4.0.0",
+    "bundlesize": "^0.18.0",
     "cross-env": "^7.0.2",
     "jest": "^25.2.3",
     "lerna": "^3.20.2",
     "nodemon": "^2.0.2",
-    "typescript": "^3.8.3"
+    "typescript": "^3.8.3",
+    "@testing-library/react": "10.2.1",
+    "@testing-library/jest-dom": "5.10.0",
+    "msw": "0.19.3",
+    "whatwg-fetch": "3.0.0"
   },
   "eslintConfig": {
     "extends": "@redwoodjs/eslint-config",
@@ -43,4 +48,4 @@
     "lint": "yarn eslint packages",
     "lint:fix": "yarn eslint --fix packages"
   }
-}
+}
\ No newline at end of file

If whatwg-fetch should be removed, should we remove the other packages too? Or should whatwg-fetch only be in this top level package.json, but moved to dependencies? The top level package.json doesn't have any other deps, only devDeps. @peterp What do you think?

Originally posted by @Tobbe in #1625 (comment)

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions