Skip to content

RSC: Add RW env var definitions to Vite config and include FatalErrorBoundary #9622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tobbe merged 3 commits into from
Dec 5, 2023
Merged

RSC: Add RW env var definitions to Vite config and include FatalErrorBoundary #9622

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a75ec29
RSC: Add RW env var definitions to Vite config and include FatalError…
Tobbe Dec 4, 2023
59dabc6
RSC: define env vars in entries.js
Tobbe Dec 4, 2023
33772d9
smoke-test for RWJS_ENV vars
Tobbe Dec 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
smoke-test for RWJS_ENV vars
  • Loading branch information
@Tobbe
Tobbe committed Dec 5, 2023
commit 33772d9c5d95e1653bfc57776350d366a1ca48d3
2 changes: 2 additions & 0 deletions packages/vite/src/rsc/rscBuildRwEnvVars.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ import fs from 'fs/promises'
* Make RW specific env vars available to server components.
* For client components this is done as a side-effect of importing from
* @redwoodjs/web (see packages/web/src/config.ts).
* The import of entries.js that we're adding this to is handled by the
* RSC worker we've got set up
*/
export async function rscBuildRwEnvVars(webDistServerEntries: string) {
await fs.appendFile(
Expand Down
9 changes: 9 additions & 0 deletions tasks/smoke-tests/rsc/tests/rsc.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,12 @@ test('Setting up RSC should give you a test project with a client side counter c

page.close()
})

test('RWJS_* env vars', async ({ page }) => {
await page.goto('/about')

await expect(page.getByText('RSC on client: enabled')).toBeVisible()
await expect(page.getByText('RSC on server: enabled')).toBeVisible()

page.close()
})