Skip to content

chore(cli): make fs modules used in the CLI consistent #9746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jtoar merged 1 commit into from
Dec 23, 2023
Merged

chore(cli): make fs modules used in the CLI consistent #9746

jtoar merged 1 commit into from
Dec 23, 2023

Conversation

@jtoar
Copy link
Contributor

@jtoar jtoar commented Dec 23, 2023

I was sizing up the CLI code as part of ESM work. Since I was looking at it wholesale, @Josh-Walker-GM and I were exchanging notes on what we'd like to improve about it. While a lot of what we talked about was out of scope, there were a few things that are low hanging fruit, one of which is this one, which amounted to a simple search and replace. We just figured if we're using fs-extra half the time in the CLI, we may as well use it everywhere to remove the overhead of why it'd be different in one place vs another.

@jtoar jtoar added the release:chore This PR is a chore (means nothing for users) label Dec 23, 2023
@jtoar jtoar added this to the next-release milestone Dec 23, 2023
@jtoar jtoar requested a review from Josh-Walker-GM December 23, 2023 10:30
@jtoar jtoar added the fixture-ok Override the test project fixture check label Dec 23, 2023
@jtoar jtoar merged commit 4cdc497 into main Dec 23, 2023
@jtoar jtoar deleted the ds-cli/fs-extra branch December 23, 2023 20:01
@jtoar jtoar mentioned this pull request Dec 24, 2023
Closed
dac09 added a commit to dac09/redwood that referenced this pull request Dec 27, 2023
@dac09
Merge branch 'fix/enhance-error-apollo-suspense' of github.com:dac09/…
dba3868 
…redwood into fix/enhance-error-apollo-suspense

* 'fix/enhance-error-apollo-suspense' of github.com:dac09/redwood: (92 commits)
  chore(deps): update dependency @types/yargs to v17.0.32 (redwoodjs#9759)
  Make it easier to find useMatch docs (redwoodjs#9756)
  chore(unit tests): Use side-effect import to fix TS errors (redwoodjs#9754)
  fix(context): Refactor context (redwoodjs#9371)
  docs: Replaced deprecated <Set private> with PrivateSet within router.md (redwoodjs#9749)
  add TS support for storybook preview tsx config extension (redwoodjs#9309)
  fix(studio): Fix windows path issues (redwoodjs#9752)
  redwoodjs#9620: Update studio to support variable components (Mailer) (redwoodjs#9639)
  chore(tasks): Add comparison view to nmHoisting visualisation (redwoodjs#9751)
  chore(cli): make fs modules used in the CLI consistent (redwoodjs#9746)
  chore(tooling): Make sure console boxen print on a new line
  chore(CI): fix publish release candidate
  feat(CLI): add check node version middleware, rm `.nvmrc`, yarn engines (redwoodjs#9728)
  docs: added some clarification on serverless functions getting executed in a non-serverless environment (redwoodjs#9742)
  Fix sshExec() errors not displaying (redwoodjs#9743)
  chore(tooling): Add missing word in release tooling output
  Update Metadata docs (redwoodjs#9744)
  chore(CI): update test project fixture and CRWA for deploy target CI repo (redwoodjs#9730)
  chore(tooling): add script for getting nested dependency data (redwoodjs#9734)
  Trusted Documents docs: Proofreading corrections (redwoodjs#9737)
  ...
dac09 added a commit to dac09/redwood that referenced this pull request Dec 27, 2023
@dac09
Merge branch 'main' of github.com:redwoodjs/redwood into fix/module-p…
09e262d 
…ath-aliases

* 'main' of github.com:redwoodjs/redwood: (92 commits)
  chore(deps): update dependency @types/yargs to v17.0.32 (redwoodjs#9759)
  Make it easier to find useMatch docs (redwoodjs#9756)
  chore(unit tests): Use side-effect import to fix TS errors (redwoodjs#9754)
  fix(context): Refactor context (redwoodjs#9371)
  docs: Replaced deprecated <Set private> with PrivateSet within router.md (redwoodjs#9749)
  add TS support for storybook preview tsx config extension (redwoodjs#9309)
  fix(studio): Fix windows path issues (redwoodjs#9752)
  redwoodjs#9620: Update studio to support variable components (Mailer) (redwoodjs#9639)
  chore(tasks): Add comparison view to nmHoisting visualisation (redwoodjs#9751)
  chore(cli): make fs modules used in the CLI consistent (redwoodjs#9746)
  chore(tooling): Make sure console boxen print on a new line
  chore(CI): fix publish release candidate
  feat(CLI): add check node version middleware, rm `.nvmrc`, yarn engines (redwoodjs#9728)
  docs: added some clarification on serverless functions getting executed in a non-serverless environment (redwoodjs#9742)
  Fix sshExec() errors not displaying (redwoodjs#9743)
  chore(tooling): Add missing word in release tooling output
  Update Metadata docs (redwoodjs#9744)
  chore(CI): update test project fixture and CRWA for deploy target CI repo (redwoodjs#9730)
  chore(tooling): add script for getting nested dependency data (redwoodjs#9734)
  Trusted Documents docs: Proofreading corrections (redwoodjs#9737)
  ...
dac09 added a commit to dac09/redwood that referenced this pull request Dec 28, 2023
@dac09
Merge branch 'main' of github.com:redwoodjs/redwood into feat/api-ski…
7db85c9 
…p-prebuild

* 'main' of github.com:redwoodjs/redwood: (1608 commits)
  Docker: Update to work with corepack and yarn v4 (redwoodjs#9764)
  [RFC]: useRoutePaths (redwoodjs#9755)
  Adds a note about the two commands you will use with your schema to the top of the schema file (redwoodjs#8589)
  docs: Supertokens.md: Fix typo (redwoodjs#9765)
  Fix supertokens docs & integration issues (redwoodjs#9757)
  fix(apollo): Enhance error differently for Suspense Cells (redwoodjs#9640)
  SSR smoke-test: Use <Metadata /> (redwoodjs#9763)
  chore(deps): update dependency @types/qs to v6.9.11 (redwoodjs#9761)
  chore(ci): Better error handling in detectChanges.mjs (redwoodjs#9762)
  fix(path-alias): Fix aliasing of paths using ts/jsconfig (redwoodjs#9574)
  chore(deps): update dependency @types/yargs to v17.0.32 (redwoodjs#9759)
  Make it easier to find useMatch docs (redwoodjs#9756)
  chore(unit tests): Use side-effect import to fix TS errors (redwoodjs#9754)
  fix(context): Refactor context (redwoodjs#9371)
  docs: Replaced deprecated <Set private> with PrivateSet within router.md (redwoodjs#9749)
  add TS support for storybook preview tsx config extension (redwoodjs#9309)
  fix(studio): Fix windows path issues (redwoodjs#9752)
  chore(tasks): Add comparison view to nmHoisting visualisation (redwoodjs#9751)
  chore(cli): make fs modules used in the CLI consistent (redwoodjs#9746)
  ...
Tobbe pushed a commit that referenced this pull request Jan 1, 2024
@jtoar @Tobbe
chore(cli): make fs modules used in the CLI consistent (#9746)
f9adcb5 
I was sizing up the CLI code as part of ESM work. Since I was looking at
it wholesale, @Josh-Walker-GM and I were exchanging notes on what we'd
like to improve about it. While a lot of what we talked about was out of
scope, there were a few things that are low hanging fruit, one of which
is this one, which amounted to a simple search and replace. We just
figured if we're using `fs-extra` half the time in the CLI, we may as
well use it everywhere to remove the overhead of why it'd be different
in one place vs another.
@jtoar jtoar modified the milestones: next-release, v7.0.0 Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Josh-Walker-GM Josh-Walker-GM Josh-Walker-GM approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fixture-ok Override the test project fixture check release:chore This PR is a chore (means nothing for users)

Projects

None yet

Milestone

v7.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@jtoar @Josh-Walker-GM