Skip to content

chore(ci): Better error handling in detectChanges.mjs #9762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tobbe merged 2 commits into from
Dec 27, 2023
Merged

chore(ci): Better error handling in detectChanges.mjs #9762

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eaa4177
chore(ci): Better error handling in detectChanges.mjs
Tobbe Dec 27, 2023
22cb8e9
Merge branch 'main' into tobbe-gh-action-detect-changes-length-0
Tobbe Dec 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
chore(ci): Better error handling in detectChanges.mjs
  • Loading branch information
@Tobbe
Tobbe committed Dec 27, 2023
commit eaa417738fa292e27c41eb9440d58ef1afa40e57
13 changes: 12 additions & 1 deletion .github/actions/detect-changes/detectChanges.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ async function getChangedFiles(page = 1) {
})

const json = await resp.json()
const files = json.map((file) => file.filename) || []
const files = json?.map((file) => file.filename) || []

changedFiles = changedFiles.concat(files)

Expand Down Expand Up @@ -78,6 +78,17 @@ async function main() {
const changedFiles = await getChangedFiles()
console.log(`${changedFiles.length} changed files`)

if (changedFiles.length === 0) {
console.log(
'No changed files found. Something must have gone wrong. Fall back to ' +
'running all tests.'
)
core.setOutput('onlydocs', false)
core.setOutput('rsc', true)
core.setOutput('ssr', true)
return
}

if (!hasCodeChanges(changedFiles)) {
console.log('No code changes detected, only docs')
core.setOutput('onlydocs', true)
Expand Down