Skip to content

packages/cli: Switch from substr (deprecated) to slice #9849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tobbe merged 1 commit into from
Jan 18, 2024
+4 −4
Merged

packages/cli: Switch from substr (deprecated) to slice #9849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/cli/src/commands/generate/service/service.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ export const buildScenario = async (model) => {
const value = scenarioData[key]

if (value && typeof value === 'string' && value.match(/^\d+n$/)) {
scenarioData[key] = `${value.substr(0, value.length - 1)}n`
scenarioData[key] = `${value.slice(0, value.length - 1)}n`
}
})

Expand All @@ -141,13 +141,13 @@ export const buildScenario = async (model) => {
export const buildStringifiedScenario = async (model) => {
const scenario = await buildScenario(model)

return JSON.stringify(scenario, (key, value) => {
return JSON.stringify(scenario, (_key, value) => {
if (typeof value === 'bigint') {
return value.toString()
}

if (typeof value === 'string' && value.match(/^\d+n$/)) {
return Number(value.substr(0, value.length - 1))
return Number(value.slice(0, value.length - 1))
}

return value
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/src/commands/generate/service/templates/test.ts.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

// BigInt
if (string.match(/^\"\d+n\"$/)) {
return string.substr(1, string.length - 2)
return string.slice(1, string.length - 1)
}

return string
Expand Down