feat(crwa): Always install using yarn v4 #9861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobbe
changed the title
Tobbe
changed the title
jtoar
added a commit
that referenced
this pull request
Jan 21, 2024
This PR fixes the CRWA e2e tests after the functionality introduced in #9861. For now I'm skipping `yarn install` since it's prone to timeouts in CI, and the subsequent step, generating types, is also flakey since `yarn pack` seems to skip the `.yarnrc.yml` which is necessary for configuring a proper install.
jtoar
pushed a commit
that referenced
this pull request
Jan 22, 2024
The check is currently running indefinitely as it is waiting for the result of a prompt. This PR passes the `--no-yarn-install` flag to prevent this. That flag was introduced in #9861
dac09
added a commit
that referenced
this pull request
Jan 22, 2024
…edwood into try/setupScenario-multiple-tests * 'try/setupScenario-multiple-tests' of github.com:dac09/redwood: (235 commits) chore(project-config): switch to vitest (#9864) chore(ci): Fix CRWA telemetry check (#9865) chore(crwa): update e2e test to handle yarn install patch (#9862) feat(crwa): Always install using yarn v4 (#9861) fix(cli): Skip Studio when running `rw upgrade` (#9860) fix(studio): Upgrade to 11.0.1 and enable web-side (#9858) feat(server file): add `createServer` (#9845) chore(crwa): set `REDWOOD_CI` and `REDWOOD_DISABLE_TELEMETRY` (#9857) Fix(crwa): Exit 0 after Quit install (#9856) chore(crwa): switch to vitest (#9855) chore(api): Switch to use vitest over jest (#9853) fix(server): ensure consistency between CLI serve entrypoints regarding help and strict (#9809) Improve how the api-server watch command works (#9841) docs(typo): correct grammar in realtime docs (#9850) Add support for Prisma Bytes and GraphQL scalar Byte (#9847) packages/cli: Switch from substr (deprecated) to slice (#9849) mapPrismaScalarToPagePropTsType: Fix Decimal test case (#9846) chore(build): Avoid prebuilding api side, instead use an esbuild plugin (#9767) Fix url query param encoding (#9844) chore(fwtools): handle existing resolutions in tarsync (#9840) ...
jtoar
pushed a commit
that referenced
this pull request
Jan 24, 2024
jtoar
pushed a commit
that referenced
this pull request
Jan 24, 2024
jtoar
added a commit
that referenced
this pull request
Jan 24, 2024
This PR fixes the CRWA e2e tests after the functionality introduced in #9861. For now I'm skipping `yarn install` since it's prone to timeouts in CI, and the subsequent step, generating types, is also flakey since `yarn pack` seems to skip the `.yarnrc.yml` which is necessary for configuring a proper install.
jtoar
pushed a commit
that referenced
this pull request
Jan 24, 2024
The check is currently running indefinitely as it is waiting for the result of a prompt. This PR passes the `--no-yarn-install` flag to prevent this. That flag was introduced in #9861
jtoar
added a commit
that referenced
this pull request
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By cd-ing into the new rw app directory we make sure
yarn installis executed by yarn v4 (or whatever version is set in the root package.json)This has a somewhat of a troubled past.
#9859
#9786 (comment)
#8164