This repository was archived by the owner on Nov 10, 2020. It is now read-only.
Some useful changes #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a26e38c.
Adding ability to cancel WaitForDevice loop.
Resources must only be extracted once as long as we have all files included & version of all binaries match the ones inside lib embedded resources. Result of this change: 1. Having binaries always available in user's temp folder (No need to extract them every time and delay apps using this library from continuing their work until our resource is in place) 2. Since our adb.exe is kept in it's place, adb daemon will be auto started on each system boot (at least that was my case), resulting in an almost instance response from apps using this library (saved 5 seconds delay when starting Droid Manager) Note: In Adb.cs internal string: ADB_VERSION must be updated on each update of adb binary or the library will NOT be extracting the new adb binary included in the embedded resources.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, the first three commits are (as you can see) not needed at all.
As for the rest: