build!: upgrade remark version #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristianMurphy
commented
Dec 12, 2020
Comment on lines
-43
to
-44
| // @ts-ignore pending https://github.com/vfile/vfile/pull/53 | ||
| .then(vfile => setReactContent(vfile.result)) |
There was a problem hiding this comment.
this was resolved in vfile
| @@ -1,5 +1,4 @@ | |||
| import React from 'react'; | |||
| import { text } from '@storybook/addon-knobs'; | |||
There was a problem hiding this comment.
migrated to storybook args
https://storybook.js.org/docs/react/writing-stories/args
| "rehype-sanitize": "^4.0.0", | ||
| "remark-math": "^4.0.0", | ||
| "tsdx": "^0.14.0", | ||
| "typescript": "^3.0.0" |
There was a problem hiding this comment.
typescript 4 will come in a future update when it has official support in tsdx jaredpalmer/tsdx#926
| uses: actions/setup-node@v1 | ||
| with: | ||
| node-version: 14 | ||
| node-version: 15 |
There was a problem hiding this comment.
upgraded CI to include and, where possible, prefer Node 15
also updates dev dependencies like tsdx and storybook
ChristianMurphy
force-pushed
the
chore/update-dependencies
branch
from
79737b2 to
b03e5d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also updates dev dependencies like tsdx and storybook