fix(git): instrument SimpleGit operations
#39591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamietanna
force-pushed
the
chore/git-instrument-impl
branch
from
4227732 to
9667590
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
secustor
reviewed
Nov 27, 2025
Member
secustor
left a comment
secustor
left a comment
There was a problem hiding this comment.
This is probably why you are getting 0ms total time
jamietanna
commented
Nov 28, 2025
jamietanna
force-pushed
the
chore/git-instrument
branch
5 times, most recently
from
521521c to
893821b
Compare
jamietanna
force-pushed
the
chore/git-instrument-impl
branch
from
9667590 to
3d76bf7
Compare
jamietanna
force-pushed
the
chore/git-instrument
branch
from
893821b to
ec20ae9
Compare
jamietanna
force-pushed
the
chore/git-instrument-impl
branch
from
3d76bf7 to
f516a62
Compare
jamietanna
force-pushed
the
chore/git-instrument
branch
from
ec20ae9 to
4d6800c
Compare
jamietanna
force-pushed
the
chore/git-instrument-impl
branch
2 times, most recently
from
4eba28c to
6e53101
Compare
jamietanna
force-pushed
the
chore/git-instrument
branch
from
4d6800c to
6cb5559
Compare
12 tasks
Contributor
Author
Moving convo into #39596 |
jamietanna
force-pushed
the
chore/git-instrument-impl
branch
from
6e53101 to
2aca5e2
Compare
viceice
reviewed
Dec 1, 2025
Now we have the basis for instrumentation for SimpleGit, we can now fully integrate it. This creates a wrapper, `InstrumentedSimpleGit`, which has a simplified interface for `SimpleGit` to allow us to focus on the important parts of the interface for what we need, instead of trying to correctly extend / implement SimpleGit's interface (and slightly complex types). In each of our methods, we then make sure we instrument it with the relevant Git subcommand being invoked. Co-authored-by: gpt-4.1 <[email protected]>
jamietanna
force-pushed
the
chore/git-instrument-impl
branch
from
2aca5e2 to
0918850
Compare
jamietanna
changed the title
SimpleGit operationsSimpleGit operations
viceice
previously approved these changes
Dec 1, 2025
Currently, SimpleGit's `getRemotes` function being passed a `verbose: false` is the same as not providing a `verbose`. This fixes the code coverage failures, as we do not call this.
viceice
approved these changes
Dec 1, 2025
Contributor
|
🎉 This PR is included in version 42.27.5 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Context
Please select one of the below:
AI assistance disclosure
Did you use AI tools to create any part of this pull request?
Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
The public repository: