-
Notifications
You must be signed in to change notification settings - Fork 2.9k
fix(gitlab): skip on unknown reviewers #39619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix(gitlab): skip on unknown reviewers #39619
Conversation
secustor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think only printing this once makes sense here
Co-authored-by: Sebastian Poxhofer <[email protected]>
Co-authored-by: Jamie Tanna <[email protected]>
Head branch was pushed to by a user without write access
viceice
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change can be done in separate PR
| return [await getUserID(r)]; | ||
| } catch { | ||
| // Unable to fetch userId, try resolve as a group | ||
| return getMemberUserIDs(r); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should change this to be similar to forgejo and GitHub. so teams need to be prefixed with team:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't that break the feature as it's not necessary to use team: prefix in the CODEOWNERS file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😕 that's disapointing. on github they are prefixed with @org/ in CODEOWNERS 🤔
Changes
Context
Please select one of the following:
reviewersFromCodeOwnersdoes not request any users if one user doesn't exist #38622AI assistance disclosure
Did you use AI tools to create any part of this pull request?
Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
The public repository: https://gitlab.com/rahultesnik/test-codeowners/-/merge_requests/8