feat(github): add support for pinning dependency dashboard issue #39634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Adds ability to pin GitHub issues via the platform API and configures the dependency dashboard to be pinned by default. This makes the dependency dashboard more visible by pinning it at the top of the repository's Issues page. Changes: - Add `isPinned` optional parameter to `EnsureIssueConfig` interface - Implement GraphQL mutations for pinning issues - Add `node_id` field to GitHub issue schema to support pinning - Update GitHub platform `ensureIssue()` to pin issues when requested - Configure dependency dashboard to set `isPinned: true` by default - Use `requestGraphql()` method for GraphQL API calls - Add explicit `TransformedIssue` type for type safety - Use nullish coalescing operator (`??`) for safer defaults The implementation uses GitHub's GraphQL API `pinIssue` mutation, which requires the issue's global node ID. Issue pinning is only performed when the `isPinned` parameter is explicitly set to true, maintaining backward compatibility with existing code. --- This PR was written primarily by Claude Code.
sgewirtz1
force-pushed
the
feat/pin-dependency-dashboard
branch
from
2ab5fd0 to
f768ded
Compare
…ance Convert TransformedIssue and CacheData from type aliases to interfaces to satisfy @typescript-eslint/consistent-type-definitions rule.
Contributor
|
Thanks! Note to reviewers: will need to review with some of the considerations from #34459 |
Contributor
|
Also, is it intentional commits are from @shimongewirtz but PR is from @sgewirtz1? Might be why the CLA is failing! |
Author
hope not, I use both interchangebly |
sgewirtz1
force-pushed
the
feat/pin-dependency-dashboard
branch
4 times, most recently
from
a2b10c0 to
8e10420
Compare
Change node_id from required 'string | undefined' to optional 'string?' to maintain backward compatibility with existing tests that don't include this property.
sgewirtz1
force-pushed
the
feat/pin-dependency-dashboard
branch
from
8e10420 to
7b6ba04
Compare
Collaborator
Nope |
RahulGautamSingh
suggested changes
Dec 1, 2025
| body: platform.massageMarkdown(issueBody, config.rebaseLabel), | ||
| labels: config.dependencyDashboardLabels, | ||
| confidential: config.confidential, | ||
| isPinned: true, |
Collaborator
There was a problem hiding this comment.
This should be configurable via a new config option, so users can decide for themselves.
Collaborator
There was a problem hiding this comment.
Please, also take a look at this comment for directions about how to set value for the new config option and whether the pinning of an issue needs additional permissions or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ability to pin GitHub issues via the platform API and configures the dependency dashboard to be pinned by default. This makes the dependency dashboard more visible by pinning it at the top of the repository's Issues page.
Changes:
isPinnedoptional parameter toEnsureIssueConfiginterfacenode_idfield to GitHub issue schema to support pinningensureIssue()to pin issues when requestedisPinned: trueby defaultThe implementation uses GitHub's GraphQL API
pinIssuemutation, which requires the issue's global node ID. Issue pinning is only performed when theisPinnedparameter is explicitly set to true, maintaining backward compatibility with existing code.This PR was written primarily by Claude Code.
Changes
Context
Please select one of the following:
AI assistance disclosure
Did you use AI tools to create any part of this pull request?
Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
The public repository: