Skip to content

Conversation

@Shegox
Copy link
Contributor

@Shegox Shegox commented Dec 5, 2025

Changes

This PR adds support for injecting credentils from the hostType: go-proxy into the GOPROXY enviroment variable when updating go modules.

This allows one to use Renovate to update dependencies which only exist in an private, authenticated GOPROXY and not e.g. in the backing version control system e.g. in Artifactory.

Lookups in the go datasource already work with authentication and hostType: go-proxy.

Additionally this PR adds some documentation for this.
In the tests I switched from mocking the hostRule resolutations to using the actual hostRule implementation allowing for easier to read and update tests.

Context

Please select one of the following:

  • This closes an existing Issue, Closes: #
  • This doesn't close an Issue, but I accept the risk that this PR may be closed if maintainers disagree with its opening or implementation

AI assistance disclosure

Did you use AI tools to create any part of this pull request?

Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.

  • No — I did not use AI for this contribution.
  • Yes — minimal assistance (e.g., IDE autocomplete, small code completions, grammar fixes).
  • Yes — substantive assistance (AI-generated non‑trivial portions of code, tests, or documentation).
  • Yes — other (please describe): Docs have been refined via GPT-5

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests, but ran on a real repository, or
  • Both unit tests + ran on a real repository

The public repository: n/a, run on a private repository on GitHub Enterprise Server with a private JFROG artifactory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant