-
Notifications
You must be signed in to change notification settings - Fork 2.9k
fix(docs): look up open issues on main builds for Renovate docs
#39801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+14
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're currently always skipping the detection of open bugs/features, so even though [0] introduced authentication to GitHub, this didn't actually lead to the lookup when running in CI. If we're not running in Renovate's CI build (i.e. as part of the release process) or the docs site's CI build (as part of post-release operations) we should continue to skip the build, when running in CI. This also makes it clearer with a WARN log line to explain why this is being skipped. [0]: renovatebot/renovatebot.github.io#746
jamietanna
commented
Dec 5, 2025
viceice
approved these changes
Dec 5, 2025
12 tasks
12 tasks
jamietanna
added a commit
that referenced
this pull request
Dec 5, 2025
* Revert "fix(docs): wire in `GH_TOKEN` for `gh` CLI (#39812)" This reverts commit 295eaac. * Revert "fix(docs): add required permissions for `build:docs` (#39809)" This reverts commit bbd30ce. * Revert "fix(docs): look up open issues on `main` builds for Renovate docs (#39801)" This reverts commit ae46c57.
Contributor
|
🎉 This PR is included in version 42.38.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
jamietanna
added a commit
that referenced
this pull request
Dec 5, 2025
…9801) We're currently always skipping the detection of open bugs/features, so even though [0] introduced authentication to GitHub, this didn't actually lead to the lookup when running in CI. If we're not running in Renovate's CI build (i.e. as part of the release process) or the docs site's CI build (as part of post-release operations) we should continue to skip the build, when running in CI. This also makes it clearer with a WARN log line to explain why this is being skipped. This is a re-apply of ae46c57, as well as making sure that the `GITHUB_TOKEN` is explicitly passed as `extraEnv`, otherwise we see i.e. ``` ERROR: Error getting query results "err": { "cmd": "/bin/sh -c gh issue list --json \"title,number,url,labels\" --search \"type:Bug\" --limit 1000", "stderr": "gh: To use GitHub CLI in automation, set the GH_TOKEN environment variable.\n", "stdout": "", "options": { "encoding": "utf-8", "env": ["CI", "HOME", "PATH", "LANG"], "maxBuffer": 10485760, "timeout": 900000 }, "exitCode": 4, "name": "ExecError", "message": "Command failed: gh issue list ...\ngh: To use GitHub CLI in automation, set the GH_TOKEN environment variable.\n", "stack": "ExecError: Command failed: gh issue list ...\ngh: To use GitHub CLI in automation, set the GH_TOKEN environment variable.\n\n at ..." } ``` As we can see, the `env` isn't automagically picking up the `GITHUB_TOKEN`, so we should explicitly pass it. [0]: renovatebot/renovatebot.github.io#746
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
We're currently always skipping the detection of open bugs/features, so
even though renovatebot/renovatebot.github.io#746 introduced authentication to GitHub, this didn't
actually lead to the lookup when running in CI.
If we're not running in Renovate's CI build (i.e. as part of the release
process) or the docs site's CI build (as part of post-release
operations) we should continue to skip the build, when running in CI.
This also makes it clearer with a WARN log line to explain why this is
being skipped.
Context
Please select one of the below:
AI assistance disclosure
Did you use AI tools to create any part of this pull request?
Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
The public repository: