refactor(npm): lockfile extraction code #7703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viceice
reviewed
Nov 12, 2020
Member
viceice
left a comment
viceice
left a comment
There was a problem hiding this comment.
Just one Question: Why switch to undefined instead of existing NaN ? Otherwise LGTM
viceice
reviewed
Nov 12, 2020
Member
viceice
left a comment
viceice
left a comment
There was a problem hiding this comment.
tested NaN vs undefined
undefined < 6 === false
undefined > 6 === false
NaN > 6 === false
NaN < 6 === falsejust a small type change
Co-authored-by: Michael Kriese <[email protected]>
rarkins
approved these changes
Nov 12, 2020
viceice
approved these changes
Nov 12, 2020
|
🎉 This PR is included in version 23.83.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Refactored lockfile extraction code.
Context:
For #7700
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: