Skip to content

Re-raise 4xx responses from server when uploading files #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattt merged 1 commit into from
Jul 5, 2024
Merged

Re-raise 4xx responses from server when uploading files #284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Re-raise 4xx responses from server when uploading files 
Fixes #270

We were falling back to base64 encoding the file data when requests to
upload the file failed. However if the client makes an invalid request
such as failing to include Authorization headers by forgetting to auth
then we should surface these errors.

This commit now re-raises any 4xx errors returned while attempting to
upload a file and adds tests to verify the behavior.
  • Loading branch information
@aron
aron committed Jul 5, 2024
commit 8469af776539ee7b3d35da2c251e45abe8217b1c
Loading