Skip to content

Deprecate stream parameter for predictions.create #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattt merged 2 commits into from
Sep 23, 2024
Merged

Deprecate stream parameter for predictions.create #291

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
896c13a
Deprecate stream parameter for predictions.create
mattt Jul 19, 2024
0a7ec78
Merge branch 'main' into mattt/deprecate-stream-parameter
mattt Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Deprecate stream parameter for predictions.create
  • Loading branch information
@mattt
mattt committed Jul 19, 2024
commit 896c13a5f3e921d658e8bac6e457077a0b02dc49
1 change: 1 addition & 0 deletions index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,6 +289,7 @@ declare module "replicate" {
model?: string;
version?: string;
input: object;
/** @deprecated */
stream?: boolean;
webhook?: string;
webhook_events_filter?: WebhookEventType[];
Expand Down
2 changes: 0 additions & 2 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,13 +304,11 @@ class Replicate {
prediction = await this.predictions.create({
...data,
version: identifier.version,
stream: true,
});
} else if (identifier.owner && identifier.name) {
prediction = await this.predictions.create({
...data,
model: `${identifier.owner}/${identifier.name}`,
stream: true,
});
} else {
throw new Error("Invalid model version identifier");
Expand Down
Loading