Skip to content

Add wait parameter to prediction creation methods #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattt merged 7 commits into from
Sep 25, 2024
Merged

Add wait parameter to prediction creation methods #308

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0a57882
Add block parameter to prediction creation methods
mattt Sep 23, 2024
eb68dd1
Add support for block: or wait: true to run
mattt Sep 23, 2024
3e4c5a3
Remove unused stream parameter
mattt Sep 23, 2024
f4e4504
Apply suggestions from code review
mattt Sep 25, 2024
7f81a4d
Replace X-Sync header with Prefer: wait
mattt Sep 25, 2024
fc0b718
Rename block to wait
mattt Sep 25, 2024
0c0245d
Normalize wait value to nonzero integer
mattt Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Normalize wait value to nonzero integer
  • Loading branch information
@mattt
mattt committed Sep 25, 2024
commit 0c0245d7feb8daf2d337de46825031e0840863a4
3 changes: 2 additions & 1 deletion lib/predictions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@ async function createPrediction(options) {
const headers = {};
if (wait) {
if (typeof wait === "number") {
headers["Prefer"] = `wait=${wait}`;
const n = Math.max(1, Math.ceil(Number(wait)) || 1);
headers["Prefer"] = `wait=${n}`;
} else {
headers["Prefer"] = "wait";
}
Expand Down