Skip to content

Extend support for useFileOutput to stream #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattt merged 5 commits into from
Sep 25, 2024
Merged

Extend support for useFileOutput to stream #309

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
254b7df
Break stream on done event without enqueuing it
mattt Sep 23, 2024
4430e6b
Fix doc comment for fetch parameter
mattt Sep 23, 2024
139fb89
Transform URLs in streaming responses when useFileOutput is enabled
mattt Sep 23, 2024
6a2156d
Revert 'Break stream on done event without enqueuing it'
mattt Sep 23, 2024
51d300b
Default to useFileOutput = true for readable streams
mattt Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Break stream on done event without enqueuing it
  • Loading branch information
@mattt
mattt committed Sep 23, 2024
commit 254b7df844a4056e50940a9c0226643aa82feea7
8 changes: 4 additions & 4 deletions lib/stream.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,10 @@ function createReadableStream({ url, fetch, options = {} }) {
.pipeThrough(new EventSourceParserStream());

for await (const event of streamAsyncIterator(stream)) {
if (event.event === "done") {
break;
}

if (event.event === "error") {
controller.error(new Error(event.data));
break;
Expand All @@ -87,10 +91,6 @@ function createReadableStream({ url, fetch, options = {} }) {
controller.enqueue(
new ServerSentEvent(event.event, event.data, event.id)
);

if (event.event === "done") {
break;
}
}

controller.close();
Expand Down