Skip to content

docs: remove duplicate steps from Readme #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aminya wants to merge 1 commit into from
Closed

docs: remove duplicate steps from Readme #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
docs: remove duplicate steps from Readme
  • Loading branch information
@aminya
aminya authored Mar 24, 2024
commit a3d54a591f4a11b717d437fcb20e2c482b26cf8e
15 changes: 3 additions & 12 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,30 +45,21 @@ jobs:
id: meta
with:
images: YOUR_IMAGE

- name: Cache var-cache-apt
id: cache-var-cache-apt
uses: actions/cache@v3
with:
path: var-cache-apt
key: var-cache-apt-${{ hashFiles('Dockerfile') }}
- name: Cache var-lib-apt
Copy link
Member

@AkihiroSuda AkihiroSuda Mar 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

var-lib-apt is not a duplicate of var-cache-apt

Copy link
Contributor Author

@aminya aminya Mar 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, okay. The code is so terse, it is hard to read. Is this boilerplate repetition needed because of not supporting an array API? Why not have an array of source-to-target maps?

Copy link
Member

@AkihiroSuda AkihiroSuda Mar 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk, maybe ask in https://github.com/actions/cache/discussions ?

Copy link
Contributor Author

@aminya aminya Mar 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actions/cache supports multiple paths in one call. It seems buildkit-cache-dance lacks this support

Copy link
Member

@AkihiroSuda AkihiroSuda Mar 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contribution is wanted to add the support

id: cache-var-lib-apt
uses: actions/cache@v3
with:
path: var-lib-apt
key: var-lib-apt-${{ hashFiles('Dockerfile') }}

- name: inject var-cache-apt into docker
uses: reproducible-containers/[email protected]
with:
cache-source: var-cache-apt
cache-target: /var/cache/apt
skip-extraction: ${{ steps.cache-var-cache-apt.outputs.cache-hit }}
- name: inject var-lib-apt into docker
uses: reproducible-containers/[email protected]
with:
cache-source: var-lib-apt
cache-target: /var/lib/apt
skip-extraction: ${{ steps.cache-var-lib-apt.outputs.cache-hit }}

- name: Build and push
uses: docker/build-push-action@v5
with:
Expand Down