Fix not preserving uid and/or gid #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks, dist/index.js needs to be regenerated |
Contributor
Author
|
Got it. Done ✅ . |
Signed-off-by: Musaed Albrikan <[email protected]>
Signed-off-by: Musaed Albrikan <[email protected]>
mabrikan
force-pushed
the
fix-not-setting-uid-and-gid
branch
from
1b24a6c to
f6f52a1
Compare
Contributor
Author
|
Last force commit is to add sign-off and make DCO happy :). |
Signed-off-by: Musaed Albrikan <[email protected]>
mabrikan
force-pushed
the
fix-not-setting-uid-and-gid
branch
from
11c7220 to
3ef5261
Compare
AkihiroSuda
approved these changes
Jun 10, 2024
Member
AkihiroSuda
left a comment
AkihiroSuda
left a comment
There was a problem hiding this comment.
Thanks, next time please squash the commits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34 .