Skip to content

Use sudo to clear cache source during extraction #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AkihiroSuda merged 2 commits into from
Jun 30, 2024
Merged

Use sudo to clear cache source during extraction #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f768744
use sudo to remove cache source in extraction
rose-m Jun 26, 2024
87d545d
create new dist
rose-m Jun 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[*.ts]
indent_style = space
indent_size = 4
Copy link
Member

@AkihiroSuda AkihiroSuda Jun 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This kind of change should be another PR

Copy link
Contributor Author

@rose-m rose-m Jul 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah sorry for that. I had to add it as otherwise auto-formatting would always start changing the indent.

9 changes: 5 additions & 4 deletions dist/index.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/index.js.map
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions src/extract-cache.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { run, runPiped } from './run.js';
async function extractCache(cacheSource: string, cacheOptions: CacheOptions, scratchDir: string) {
// Prepare Timestamp for Layer Cache Busting
const date = new Date().toISOString();

await fs.mkdir(scratchDir, { recursive: true });
await fs.writeFile(path.join(scratchDir, 'buildstamp'), date);

Expand Down Expand Up @@ -42,7 +42,7 @@ RUN --mount=${mountArgs} \
);

// Move Cache into Its Place
await fs.rm(cacheSource, { recursive: true, force: true });
await run('sudo', ['rm', '-rf', cacheSource]);
await fs.rename(path.join(scratchDir, 'dance-cache'), cacheSource);
}

Expand Down