Allow overriding container image #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
reviewed
Oct 18, 2024
AkihiroSuda
reviewed
Oct 18, 2024
Member
Alternatively we may consider just using https://github.com/containerd/containerd/pkgs/container/busybox to avoid the Docker Hub rate limit? |
Contributor
Author
|
Using the GHCR image as a default makes sense. I think it's still valuable to allow overriding the default container image. |
relu
force-pushed
the
custom-image
branch
3 times, most recently
from
8495185 to
a6159df
Compare
Contributor
Author
|
@AkihiroSuda I just got back to this and noticed that the |
Fixes reproducible-containers#42 Signed-off-by: Aurel Canciu <[email protected]>
AkihiroSuda
approved these changes
Nov 11, 2024
Member
AkihiroSuda
left a comment
AkihiroSuda
left a comment
There was a problem hiding this comment.
Thanks, the BusyBox image is outdated, but I assume practically it doesn't matter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42
Not sure if the built dist files should be included in the PR or not. Let me know and I can remove them if needed.