Skip to content

Conversation

@ty2
Copy link
Contributor

@ty2 ty2 commented Nov 7, 2024

Introduced builder arguments to specify custom builder.

@AkihiroSuda
Copy link
Member

AkihiroSuda commented Nov 12, 2024

Please rebase and rebuild the dist:

Also please squash the commits

@ty2
Copy link
Contributor Author

ty2 commented Nov 12, 2024

Please rebase and rebuild the dist:

Also please squash the commits

Done.

@AkihiroSuda
Copy link
Member

Commits do not seem squashed

https://www.freecodecamp.org/news/git-squash-commits/

@ty2 ty2 force-pushed the main branch 2 times, most recently from dd860b2 to ba9d021 Compare November 12, 2024 05:47
Signed-off-by: Terry Wong <[email protected]>

rebuild

Signed-off-by: Terry Wong <[email protected]>
@ty2
Copy link
Contributor Author

ty2 commented Nov 12, 2024

Sorry, I'm not familiar with Git. It looks like the commits have been squashed. Could you check if there are any issues?

Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit 61bd187 into reproducible-containers:main Nov 13, 2024
3 checks passed
@kkopachev
Copy link

Hardcoding default builder name would break github actions setup with setup-buildx-action as it creates new builder with unique name and sets it as default, while the builder named default still exists, it is not selected for builds. When this action specifies --builder default it will use another builder, not the one for actual payload builds

@kkopachev
Copy link

I'd suggest using BUILDX_BUILDER environment variable instead of introducing new argument

@slinkydeveloper
Copy link

Stumbled on this in CI, used in combination with setup-buildx-action:

Run reproducible-containers/buildkit-cache-dance@v3

FROM ghcr.io/containerd/busybox:latest
COPY buildstamp buildstamp
RUN --mount=type=cache,target=/var/cache/sccache     --mount=type=bind,source=.,target=/var/dance-cache     cp -p -R /var/dance-cache/. /var/cache/sccache  || true

Error running command: docker buildx build --builder default -f scratch/Dancefile.inject --tag dance:inject sccache-cache
ERROR: use `docker --context=default buildx` to switch to context "default"

@slinkydeveloper
Copy link

Pinning the action version to 3.1.2 fixes it for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants