changelog + fix

CHANGELOG.md

@@ -34,6 +34,7 @@
 - Emit `%todo` instead of `failwith("TODO")` when we can (ReScript >= v11.1). https://github.com/rescript-lang/rescript-vscode/pull/981
 - Complete `%todo`. https://github.com/rescript-lang/rescript-vscode/pull/981
 - Add code action for extracting a locally defined module into its own file. https://github.com/rescript-lang/rescript-vscode/pull/983
+- Add code action for expanding catch-all patterns. https://github.com/rescript-lang/rescript-vscode/pull/987
 
 ## 1.50.0
 

analysis/src/Xform.ml

@@ -532,7 +532,7 @@ module ExpandCatchAllForVariants = struct
               "Some("
               ^ (missingConstructors
                 |> List.map (fun (name, hasArgs) ->
-                       name ^ if hasArgs then "" else "(_)")
+                       name ^ if hasArgs then "(_)" else "")
                 |> String.concat " | ")
               ^ ")"
             in

analysis/tests/src/expected/Xform.res.txt

@@ -238,7 +238,7 @@ TextDocumentEdit: Xform.res
 {"start": {"line": 96, "character": 2}, "end": {"line": 96, "character": 3}}
 newText:
   <--here
-  Some(Second(_) | Third(_) | Fourth) | None
+  Some(Second | Third | Fourth(_)) | None
 
 Xform src/Xform.res 105:4
 posCursor:[102:16] posNoWhite:[102:14] Found expr:[102:9->107:1]
@@ -255,5 +255,5 @@ TextDocumentEdit: Xform.res
 {"start": {"line": 105, "character": 2}, "end": {"line": 105, "character": 3}}
 newText:
   <--here
-  Some(#"illegal identifier"(_) | #second(_) | #third)
+  Some(#"illegal identifier" | #second | #third(_))