Skip to content

Remove warnings that no longer exist from Bsc_warnings.default_w #7413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 4, 2025
+13 −39
Merged

Remove warnings that no longer exist from Bsc_warnings.default_w #7413

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c60456b
Remove warnings 40, 42 and 61 from the list of default warnings
mediremi May 1, 2025
5f3b4f7
Remove description for warning 61 as it no longer exists
mediremi May 1, 2025
2fedde4
Update descriptions of warnings in default list
mediremi May 1, 2025
fb6711d
Add CHANGELOG entry
mediremi May 1, 2025
7d8d526
Remove descriptions for removed warnings 51 and 6
mediremi May 1, 2025
df89772
s/OCaml/ReScript
mediremi May 1, 2025
5ec4365
Format
mediremi May 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Remove warnings 40, 42 and 61 from the list of default warnings
  • Loading branch information
@mediremi
mediremi committed May 1, 2025
commit c60456bbb70a02cb69832a7b25a660632e16f2da
2 changes: 1 addition & 1 deletion compiler/ext/bsc_warnings.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
- 102 Bs_polymorphic_comparison
*)
(* If you change this, don't forget to adapt docs/docson/build-schema.json as well. *)
let defaults_w = "+a-4-9-20-40-41-42-50-61-102"
let defaults_w = "+a-4-9-20-41-50-102"

let defaults_warn_error = "-a+5+6+101+109"
(*TODO: add +10*)
2 changes: 1 addition & 1 deletion docs/docson/build-schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,7 +440,7 @@
"properties": {
"number": {
"type": "string",
"description": "Default: \"+a-4-9-20-40-41-42-50-61-102\". Go [here](https://rescript-lang.org/docs/manual/latest/warning-numbers) for the meanings of the warning flags"
"description": "Default: \"+a-4-9-20-41-50-102\". Go [here](https://rescript-lang.org/docs/manual/latest/warning-numbers) for the meanings of the warning flags"
},
"error": {
"oneOf": [
Expand Down