Skip to content

Conversation

@t3mi
Copy link

@t3mi t3mi commented Aug 11, 2023

  • Adds build_info prometheus metric

@jmos5156

This comment was marked as spam.

@t3mi
Copy link
Author

t3mi commented Aug 29, 2023

@mustafaakin any chance for review?

@smelchior
Copy link

We would also very much like to get this merged, as we are loosing events currently.

@jmos5156

This comment was marked as spam.

@mustafaakin
Copy link

We can merge this, however it has 2 features. The build info is OK, great. However, the calling update on every update should be optional otherwise all the new releases will get substantially larger amount of events. If you can separate this, I'd be glad to merge the build info.

Additionally, go 1.18 introduced a new package for natively accessing build information. https://shibumi.dev/posts/go-18-feature/ It'd be great to use it.

@jmos5156

This comment was marked as spam.

@mustafaakin mustafaakin merged commit b892cb2 into resmoio:master Oct 25, 2023
@t3mi t3mi deleted the vm branch October 27, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants