Skip to content

Add more visibility for dropped events #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Dec 19, 2022
Merged

Add more visibility for dropped events #37

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
4e4c00b
add warn for when event is discarded
Evedel Nov 18, 2022
82cc6a1
add events discarded metrics
Evedel Nov 18, 2022
c229a99
drop event onUpdate subscription
Evedel Nov 18, 2022
a02e5f9
rename ThrottlePeriod -> MaxEventAgeSeconds
Evedel Nov 18, 2022
377806a
update readme to match new name of config var
Evedel Nov 18, 2022
7bf1013
add explicit go arch
Evedel Nov 18, 2022
a5d14db
gofmt
Evedel Nov 18, 2022
3a00e11
add config tests
Evedel Nov 19, 2022
933214c
revert accidental change to dockerfile
Evedel Nov 19, 2022
8363b07
add tests for event MaxEventAgeSeconds
Evedel Nov 19, 2022
4412484
add tests for event discarded to onEvent function
Evedel Nov 21, 2022
08ac2e2
Use custom role with wider read permissions (#2)
Evedel Nov 26, 2022
9946c91
Merge branch 'main' into add-more-visibility-for-dropped-events
Evedel Nov 26, 2022
3b176bc
use longer time intervals for more stable tests on slower ci
Evedel Nov 26, 2022
b0fab5a
fix failing config test
Evedel Nov 26, 2022
5e32187
Merge branch 'master' into add-more-visibility-for-dropped-events
Evedel Dec 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
add warn for when event is discarded
  • Loading branch information
@Evedel
Evedel committed Nov 18, 2022
commit 4e4c00b76f82efd5020a28fb149de21e2620c5d0
13 changes: 12 additions & 1 deletion pkg/kube/watcher.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ var (
Name: "watch_errors",
Help: "The total number of errors received from the informer",
})

startUpTime = time.Now()
)

type EventHandler func(event *EnhancedEvent)
Expand Down Expand Up @@ -74,7 +76,16 @@ func (e *EventWatcher) onEvent(event *corev1.Event) {
if timestamp.IsZero() {
timestamp = event.EventTime.Time
}
if time.Since(timestamp) > e.throttlePeriod {

eventAge := time.Since(timestamp)
if eventAge > e.throttlePeriod {
if time.Now().Sub(startUpTime) > eventAge {
log.Warn().
Str("event age", eventAge.String()).
Str("event namespace", event.Namespace).
Str("event name", event.Name).
Msg("Event discarded as being older then throttlePeriod")
}
return
}

Expand Down