Add a check in background plugin to prevent undefined background styles injected #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If background plugin is used at the same time as DOM elements that is set to lazy load, the background plugin incorrectly also injects a background-image style to each element. This causes a lot of undefined image loading ```style="background-image: url(http://magento.zabadaclean.biz/undefined);"``` This fix ads a check to determine that an element has a valid defined bgAttr set.
|
Hi! I'm having this issue for a while now! So glad I could find this! My NewRelic logs are filled with 410 and I had no idea it was from these plugins because I wasn't able to replicate it on development for ages 😄 @ressio could you please consider merging this PR from @ProxiBlue? Hope to hear from you! |
|
Experiencing the same issue, please consider merging |
|
Seeing same issue, please merge a fix; or explain how to prevent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If background plugin is used at the same time as DOM elements that is set to lazy load, the background plugin incorrectly also injects a background-image style to each element. This causes a lot of undefined image loading
style="background-image: url(http://magento.zabadaclean.biz/undefined);"This fix ads a check to determine that an element has a valid defined bgAttr set.