Skip to content

v109 #1963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Mar 12, 2023
Merged

v109 #1963

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
d2c33ab
Added .NET Framework 471 as a target. .NET 5 is out
alexeyzimarev Nov 8, 2022
c8b9f65
Merge branch 'dev' into v109
alexeyzimarev Nov 11, 2022
a63d57f
Merge with dev
alexeyzimarev Nov 11, 2022
193b6ca
Fix the media type issue with .NET 7 #1969
alexeyzimarev Nov 16, 2022
a4473c3
Fixing OAuth1 tests
alexeyzimarev Nov 16, 2022
7be39f5
Interface, configuration
alexeyzimarev Nov 19, 2022
85be2f4
Merge branch 'dev' into v109
alexeyzimarev Nov 20, 2022
b94e766
String type for ContentType
alexeyzimarev Nov 20, 2022
19c30a8
Refactoring tests
alexeyzimarev Nov 21, 2022
7e0a1af
Added Authenticator to RestRequest
alexeyzimarev Feb 16, 2023
fc036ab
Remove unused using
alexeyzimarev Feb 17, 2023
7e8694d
Use 7.0.102 due to .NET breaking change
alexeyzimarev Feb 17, 2023
3a9fe6d
Don't pack source gen
alexeyzimarev Feb 17, 2023
1d289f9
Ignore exceptions parsing response cookies (#2015)
fcastells Mar 4, 2023
27272f3
Fixing the file upload test
alexeyzimarev Mar 4, 2023
90e70fc
V109 (#2010)
EdLichtman Mar 4, 2023
cdc020d
Merge branch 'dev' into v109
alexeyzimarev Mar 4, 2023
d284f78
Related changes in the docs
alexeyzimarev Mar 5, 2023
b9753f6
Added a simple factory with opt-in
alexeyzimarev Mar 12, 2023
6174a29
Add factory docs
alexeyzimarev Mar 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixing OAuth1 tests
  • Loading branch information
@alexeyzimarev
alexeyzimarev committed Nov 16, 2022
commit a4473c35fc335eecf59eca2db3c340bc7ee6cab8
96 changes: 20 additions & 76 deletions test/RestSharp.Tests/OAuth1AuthenticatorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,81 +70,25 @@ public void Authenticate_ShouldAddSignatureToRequestAsSeparateParameters_OnUrlOr

// Assert
var parameters = request.Parameters;

Assert.NotNull(
parameters.FirstOrDefault(
x => x.Type == ParameterType.GetOrPost &&
x.Name == "x_auth_username" &&
(string)x.Value == "ClientUsername" &&
x.ContentType == null
)
);

Assert.NotNull(
parameters.FirstOrDefault(
x => x.Type == ParameterType.GetOrPost &&
x.Name == "x_auth_password" &&
(string)x.Value == "ClientPassword" &&
x.ContentType == null
)
);

Assert.NotNull(
parameters.FirstOrDefault(
x => x.Type == ParameterType.GetOrPost && x.Name == "x_auth_mode" && (string)x.Value == "client_auth" && x.ContentType == null
)
);

Assert.NotNull(
parameters.FirstOrDefault(
x => x.Type == ParameterType.GetOrPost &&
x.Name == "oauth_consumer_key" &&
(string)x.Value == "ConsumerKey" &&
x.ContentType == null
)
);

Assert.NotNull(
parameters.FirstOrDefault(
x => x.Type == ParameterType.GetOrPost &&
x.Name == "oauth_signature" &&
!string.IsNullOrWhiteSpace((string)x.Value) &&
x.ContentType == null
)
);

Assert.NotNull(
parameters.FirstOrDefault(
x => x.Type == ParameterType.GetOrPost &&
x.Name == "oauth_signature_method" &&
(string)x.Value == "PLAINTEXT" &&
x.ContentType == null
)
);

Assert.NotNull(
parameters.FirstOrDefault(
x => x.Type == ParameterType.GetOrPost && x.Name == "oauth_version" && (string)x.Value == "Version" && x.ContentType == null
)
);

Assert.NotNull(
parameters.FirstOrDefault(
x => x.Type == ParameterType.GetOrPost &&
x.Name == "oauth_nonce" &&
!string.IsNullOrWhiteSpace((string)x.Value) &&
x.ContentType == null
)
);

Assert.NotNull(
parameters.FirstOrDefault(
x => x.Type == ParameterType.GetOrPost &&
x.Name == "oauth_timestamp" &&
!string.IsNullOrWhiteSpace((string)x.Value) &&
x.ContentType == null
)
);
ParameterShouldBe("x_auth_username", "ClientUsername");
ParameterShouldBe("x_auth_password", "ClientPassword");
ParameterShouldBe("x_auth_mode", "client_auth");
ParameterShouldBe("oauth_consumer_key", "ConsumerKey");
ParameterShouldHaveValue("oauth_signature");
ParameterShouldBe("oauth_signature_method", "PLAINTEXT");
ParameterShouldBe("oauth_version", "Version");
ParameterShouldHaveValue("oauth_nonce");
ParameterShouldHaveValue("oauth_timestamp");

void ParameterShould(string name, Func<Parameter, bool> check) {
var parameter = parameters.FirstOrDefault(x => x.Type == ParameterType.GetOrPost && x.Name == name);
parameter.Should().NotBeNull();
check(parameter).Should().BeTrue();
}

void ParameterShouldBe(string name, string value) => ParameterShould(name, x => (string)x.Value == value);

void ParameterShouldHaveValue(string name) => ParameterShould(name, x => !string.IsNullOrWhiteSpace((string)x.Value));
}

[Theory]
Expand Down Expand Up @@ -200,4 +144,4 @@ public void Authenticate_ShouldAllowEmptyConsumerSecret_OnHttpAuthorizationHeade
Assert.Contains("OAuth", value!);
Assert.Contains($"oauth_signature=\"{OAuthTools.UrlEncodeStrict("&")}", value);
}
}
}