-
Notifications
You must be signed in to change notification settings - Fork 5
Feature/refactor api #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
da26127
Change identifier to name
jodiedunlop 6745120
Change static method valueFor() to valueForKey()
jodiedunlop df27a89
Add static method nameForKey()
jodiedunlop 6400bb8
Change exists() and checkExists() to isValidKey() and requireValidKey…
jodiedunlop ce9166e
Improve keyForName()
jodiedunlop 078f0a7
Fix error in key() when the key is not a string (eg. int)
jodiedunlop 1f024a9
Fix is() instance method to handle non-string keys
jodiedunlop ad4f245
Fix late-static binding: change self references
jodiedunlop d159b97
Add Enum::instanceFromName() method
jodiedunlop 10162b7
Change implementation of instanceFromKey() to use array_search
jodiedunlop c865499
Rename some internal variables
jodiedunlop 434d78b
Removed flip() and renamed fromValue() to keyForValue()
jodiedunlop b1e9572
Change nameForKey implementation and throw on duplicate keys
jodiedunlop 257ab25
Add uncommitted duplicate key classes
jodiedunlop 549f8d3
Rename Enum::constantMap() method to namesAndKeys()
jodiedunlop f1e6c52
Update README to document API changes
jodiedunlop 2031ec1
Add Enum::valueForName() method
jodiedunlop c616f17
Rename Bevs stub to Beverages
jodiedunlop 903e409
Fix isValidName() to handle null keys
jodiedunlop 32e71ee
Update CHANGELOG for 2.0.0 release
jodiedunlop File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Change static method valueFor() to valueForKey()
- Loading branch information
commit 6745120e1c103abbc9b6f0cdfe1551085ef52d21
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enum::valueForName()for completeness?