Skip to content

Fix json display in leaderboards#7873

Draft
ericokuma wants to merge 1 commit into
mainfrom
cursor/APP-308-fix-json-display-in-leaderboards-c49e
Draft

Fix json display in leaderboards#7873
ericokuma wants to merge 1 commit into
mainfrom
cursor/APP-308-fix-json-display-in-leaderboards-c49e

Conversation

@ericokuma

Copy link
Copy Markdown
Contributor

Fixes APP-308: Display JSON in leaderboards and dimension tables, and enable filtering.

Previously, JSON dimension values were displayed as [object Object] and caused SQL errors (unsupported type map[string]interface {}) when filtered. This PR introduces a formatDimensionValue helper to properly stringify JSON, STRUCT, MAP, and ARRAY types. This ensures correct display in leaderboards and dimension tables, and allows filtering on these values without errors by passing stringified JSON to the backend.

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes (APP-308)
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

Linear Issue: APP-308

Open in Cursor Open in Web

Co-authored-by: eric.okuma <eric.okuma@rilldata.com>
@cursor

cursor Bot commented Sep 3, 2025

Copy link
Copy Markdown

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants