Improve visual metrics editor model/table selection logic#7907
Draft
ericokuma wants to merge 1 commit into
Draft
Improve visual metrics editor model/table selection logic#7907ericokuma wants to merge 1 commit into
ericokuma wants to merge 1 commit into
Conversation
Co-authored-by: eric.okuma <eric.okuma@rilldata.com>
|
Cursor Agent can help with this pull request. Just |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses APP-309 by improving the Visual Metrics Editor's logic for selecting models and tables.
The core problem was that the editor struggled with MotherDuck tables (which are not Rill models), leading to incorrect YAML generation and a confusing UI.
This PR resolves the issue by:
OLAPListTablesfor surfacing available options, ensuring all tables (including external ones) are discoverable.model: <table_name>for tables in the default database/schema, anddatabase: <database>, database_schema: <database_schema>, table: <table_name>for tables outside the default context.This ensures a consistent and correct experience for all table selections in the Visual Metrics Editor.
Checklist:
Linear Issue: APP-309