feat: .env UI editor by royendo · Pull Request #8520 · rilldata/rill

royendo · 2025-12-16T15:51:03Z

QA: https://www.loom.com/share/d863c0a6eb3c404d9a24b49c280ca4ac

Adds a visual editor for .env files in Rill Developer with push/pull sync to Rill Cloud.

No-code table view for adding, editing, and deleting environment variables alongside the raw code editor
Pull/Push buttons to merge variables between local .env and Rill Cloud (disabled when project is not linked, with contextual tooltips)
"View in Cloud" link for admins to jump to the cloud env vars settings page
Import .env file support in the Add dialog
Platform-aware keyboard hints, stable {#each} keys, toast notifications on all CRUD operations
Uses dotenv parser consistently (no custom parser)

Decision: We dont need to support all CLI paths, just the main one. From the UI, we wont add support for --path unless specifically asked for it. We can add an Advanced Tab in the dropdown UI in the future.

Checklist:

Covered by tests
Ran it and it works as intended
Reviewed the diff before requesting a review
Checked for unhandled edge cases
Linked the issues it closes
Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
Intend to cherry-pick into the release branch
I'm proud of this work!

royendo · 2025-12-16T16:05:00Z

where to consolidate utils?
web-common/src/features/environment-variables/utils.ts
and
web-admin/src/features/projects/environment-variables/utils.ts

have the same functions and lots of repeat since they are the same functionality

royendo · 2025-12-17T18:27:42Z

Before Deploy:

After Deploy:

Code view Before Deploy:

looks like we didnt habe this already so claude code/cursor did some work and i rebuild proto... since its new feature it shouldnt effect anything else

royendo · 2025-12-17T19:32:06Z

@begelundmuller , based on Mike's requests to add push-pull button in the UI here: https://rilldata.slack.com/archives/C01A9DYP013/p1765989576246559?thread_ts=1765901488.470909&cid=C01A9DYP013

required some new backend changes, so tagging you as a reviewer for this PR, as well.

If this is "too complicated" or adds brittleness to the code base, we can remove the backend changes and buttons for this PR and tackle it in a dedicated PR in the future.

Thoughts?

begelundmuller

The backend code here seems correct at a high level, although it could do with some cleaning up (there are some anti-patterns and no tests)

royendo · 2026-01-20T16:09:05Z

Code Review

Professionalism & Code Quality: ⭐⭐⭐⭐⭐ (Excellent)

Strengths:

Comprehensive implementation of PullEnv and PushEnv RPC handlers
Good use of maps.Equal for checking if variables are up to date
Proto definitions are clean with proper comments

Issues to Address:

Error handling could be more specific in cli/pkg/local/server.go:717:
```
return nil, fmt.Errorf("failed to write .env file: %w", err)
```
Consider distinguishing between permission errors and other I/O errors.
Default environment assumption - The PullEnv defaults to "dev" which may surprise users expecting "prod".

E2E Testing: ⚠️ Missing

No E2E tests for pull/push env functionality.

Recommendations:

Add E2E test for rill env pull CLI command
Test conflict resolution when local and cloud variables differ
Test authentication required scenarios

General Comments:

The merge strategy (local first, then cloud overwrites) is clear and documented in the request/response messages
Good use of EnsureGitignoreHasDotenv for security

royendo · 2026-01-22T22:10:36Z

Just spoke to Mike and got confirmed that we want this in UI

k-anshul · 2026-04-10T12:04:38Z

+		maps.Copy(vars, existing)
+		maps.Copy(vars, resVars)
+		path := pathForEnv(env)
+		err = godotenv.Write(vars, filepath.Join(projectPath, path))


This means vars from deep .env file like model/.env gets rewritten to root .env. But it was the same behaviour earlier also. Not sure if it was a bug.

begelundmuller · 2026-04-20T15:52:04Z

+  // PullEnv pulls environment variables from cloud to local .env file
+  rpc PullEnv(PullEnvRequest) returns (PullEnvResponse) {
+    option (google.api.http) = {
+      post: "/v1/instances/{instance_id}/env/pull",
+      body: "*"
+    };
+  }


Could this functionality be covered by the existing ReloadConfig function?

Since in cloud, admin calls ReloadConfig on all runtimes when a variable is changed; so ReloadConfig already serves the purpose of triggering re-pull of variables.

But ReloadConfig is a no-op for rill developer and it is used in web-local UI as well.
I can route it to ReloadConfig for cloud runtimes if we want to avoid env updates from two places.

Discussed separately; Anshul will update with his findings.

begelundmuller · 2026-04-20T16:00:05Z

 	ProvisionConnector(ctx context.Context, name, driver string, args map[string]any) (map[string]any, error)
 	GetDeploymentConfig(ctx context.Context) (*DeploymentConfig, error)
 	ListDeployments(ctx context.Context) ([]*Deployment, error)
+	GetProjectVariables(ctx context.Context, environment string) (map[string]map[string]string, error)


Same question as earlier – isn't this already covered by GetDeploymentConfig?

Same - local runtimes can't use GetDeploymentConfig

Co-authored-by: Benjamin Egelund-Müller <b@egelund-muller.com>

begelundmuller · 2026-04-24T11:56:50Z

FYI the backend implementation has been extracted into this PR: #9294

royendo · 2026-04-29T13:40:31Z

okay, ill rework this to a UI only PR after rebasing with main

This reverts commit 1c48d6d.

# Conflicts: # admin/server/deployment.go # cli/cmd/env/push.go # cli/pkg/local/admin.go # cli/pkg/local/app.go # docs/docs/reference/cli/env/push.md # proto/gen/rill/admin/v1/api.pb.go # proto/gen/rill/runtime/v1/api.pb.go # proto/gen/rill/runtime/v1/api.pb.gw.go # proto/gen/rill/runtime/v1/api.pb.validate.go # proto/gen/rill/runtime/v1/api_grpc.pb.go # proto/gen/rill/runtime/v1/runtime.swagger.yaml # proto/rill/runtime/v1/api.proto # runtime/config_reloader.go # runtime/runtime.go # runtime/server/env.go # runtime/server/instances.go # web-admin/src/routes/[organization]/[project]/-/settings/environment-variables/+page.svelte # web-common/src/proto/gen/rill/runtime/v1/api_connect.ts # web-common/src/proto/gen/rill/runtime/v1/api_pb.ts # web-common/src/runtime-client/v2/gen/runtime-service.ts # web-local/src/routes/(application)/(workspace)/files/[...file]/+page.svelte

royendo added 4 commits December 16, 2025 10:39

init functinoality

0185c0a

nit fix for saving

47c11ed

prettier

8b57993

code qual

0da0d0f

royendo added 3 commits December 16, 2025 11:05

pretty

e50214e

qual

da5d2c1

adding buttons

7ba537f

royendo added 3 commits December 17, 2025 13:30

mangeprjoect access only

d155dbb

simple UI will replace

6edc05b

push/pull functionality

6e89198

looks like we didnt habe this already so claude code/cursor did some work and i rebuild proto... since its new feature it shouldnt effect anything else

royendo requested a review from mindspank December 17, 2025 19:17

royendo requested a review from begelundmuller December 17, 2025 19:32

begelundmuller reviewed Dec 18, 2025

View reviewed changes

royendo mentioned this pull request Jan 20, 2026

feat: part 2 Env new behavior: OS Fallback and alert #8641

Closed

8 tasks

royendo requested a review from begelundmuller January 22, 2026 22:10

royendo added 5 commits February 5, 2026 14:34

Merge branch 'main' into feat/env-ui-editor

dadaa3d

change button to disabled if no project synced

3fa7726

update behavior

17c7cf8

code fail

6d432c6

code qual + prettier

d1ce955

begelundmuller requested review from k-anshul and removed request for begelundmuller February 18, 2026 13:35

k-anshul added 3 commits February 20, 2026 13:18

migrate APIs to runtime

89c4be7

Merge remote-tracking branch 'origin/main' into feat/env-ui-editor

e7f9123

prettier fixes

b84fd15

royendo and others added 6 commits March 30, 2026 12:15

prettier

d142b6a

code qual

0a32b5b

go code

830c38b

Merge remote-tracking branch 'origin/main' into feat/env-ui-editor

be2686c

simplification

5523577

more simplifactions

e0b3845

k-anshul reviewed Apr 10, 2026

View reviewed changes

add code removed by merge conflicts

2d0d9c9

begelundmuller requested changes Apr 20, 2026

View reviewed changes

k-anshul and others added 11 commits April 21, 2026 10:23

Merge remote-tracking branch 'origin/main' into feat/env-ui-editor

1ca1e0a

Update proto/rill/admin/v1/api.proto

9856b6e

Co-authored-by: Benjamin Egelund-Müller <b@egelund-muller.com>

review comments - 1

024f8dd

fixes

76fc504

remove getvariables

1256607

lint fix

04bd4bf

use repo functions

5242b97

Merge remote-tracking branch 'origin/main' into feat/env-ui-editor

86489f3

remove pull env api

fa5a8c2

lint fix

ae6093c

init map

9aef5d2

git merge main

1c48d6d

royendo requested review from a team as code owners April 29, 2026 15:46

royendo marked this pull request as draft April 29, 2026 15:49

royendo added 4 commits April 29, 2026 11:53

Revert "git merge main"

a6420bb

This reverts commit 1c48d6d.

Restore PullEnv runtime API and frontend Pull dialog

d8e94b9

revert

73b0b8b

Conversation

royendo commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

royendo commented Dec 16, 2025

Uh oh!

royendo commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

royendo commented Dec 17, 2025

Uh oh!

begelundmuller left a comment

Choose a reason for hiding this comment

Uh oh!

royendo commented Jan 20, 2026

Code Review

Professionalism & Code Quality: ⭐⭐⭐⭐⭐ (Excellent)

E2E Testing: ⚠️ Missing

General Comments:

Uh oh!

royendo commented Jan 22, 2026

Uh oh!

k-anshul Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

begelundmuller Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

k-anshul Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

begelundmuller Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

begelundmuller Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

k-anshul Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

begelundmuller commented Apr 24, 2026

Uh oh!

royendo commented Apr 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

royendo commented Dec 16, 2025 •

edited

Loading

royendo commented Dec 17, 2025 •

edited

Loading