Skip to content

chore: refactor instanceid handling #8572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
briangregoryholmes wants to merge 16 commits into
base: main
Choose a base branch
from
Draft

chore: refactor instanceid handling #8572

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
47096b6
fix: canvas to org navigation
briangregoryholmes Dec 22, 2025
92d6be5
remove unused import
briangregoryholmes Dec 22, 2025
2e7d422
add test
briangregoryholmes Dec 22, 2025
b4e434b
test fix
briangregoryholmes Dec 22, 2025
ede5105
cleanup
briangregoryholmes Dec 23, 2025
28e1564
unintended change
briangregoryholmes Dec 23, 2025
84254b2
remove comment
briangregoryholmes Dec 23, 2025
13710b2
revert change
briangregoryholmes Dec 23, 2025
5c9f4c1
remove import
briangregoryholmes Dec 23, 2025
d8e0115
type fix
briangregoryholmes Dec 24, 2025
613a78e
Merge branch 'main' into bgh/fix-canvas-to-org-navigation
briangregoryholmes Dec 24, 2025
8bab081
Fix issues with other parts of runtime
AdityaHegde Dec 24, 2025
a2ecdcf
fix baseUrl issue
briangregoryholmes Dec 24, 2025
818744a
chore: refactor instanceid handling
briangregoryholmes Dec 24, 2025
a33a338
cleanup
briangregoryholmes Dec 24, 2025
9423c29
cleanup and prettier
briangregoryholmes Dec 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
revert change
  • Loading branch information
@briangregoryholmes
briangregoryholmes committed Dec 23, 2025
commit 13710b2963e68e3abb6384211759c05a940f1d84
6 changes: 3 additions & 3 deletions web-common/src/features/canvas/CanvasLoadingState.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,9 @@
</script>

<div class="size-full justify-center items-center flex flex-col">
{#if errorMessage}
{#if ready}
<slot />
{:else if errorMessage}
<ErrorPage
statusCode={404}
header="Canvas not found"
Expand All @@ -20,8 +22,6 @@
<DashboardBuilding />
{:else if isLoading}
<DelayedSpinner isLoading={true} size="48px" />
{:else if ready}
<slot />
{:else}
<header
role="presentation"
Expand Down
Loading